Fix bug in get_cluster_info

knizhnik · kelvich · commit 45c3a43aef0f · 2017-11-13T00:17:03.000+03:00
diff --git a/multimaster.c b/multimaster.c
@@ -460,6 +460,7 @@ MtmAdjustOldestXid(TransactionId xid)
 	MtmTransState *ts = (MtmTransState*)hash_search(MtmXid2State, &xid, HASH_FIND, NULL);
 	MTM_LOG2("%d: MtmAdjustOldestXid(%d): snapshot=%ld, csn=%ld, status=%d", MyProcPid, xid, ts != NULL ? ts->snapshot : 0, ts != NULL ? ts->csn : 0, ts != NULL ? ts->status : -1);
 	Mtm->gcCount = 0;
+
 	if (ts != NULL) { 
 		oldestSnapshot = ts->snapshot;
 		Mtm->nodes[MtmNodeId-1].oldestSnapshot = oldestSnapshot;
@@ -486,6 +487,7 @@ MtmAdjustOldestXid(TransactionId xid)
 			}
 		}
 	} 
+
 	if (MtmUseDtm) 
 	{ 
 		if (prev != NULL) { 
@@ -2536,7 +2538,6 @@ mtm_get_cluster_info(PG_FUNCTION_ARGS)
 	tuple = BuildTupleFromCStrings(funcctx->attinmeta, values);
 	PQclear(result);
 	PQfinish(conn);
-	usrfctx->nodeId += 1;
 	SRF_RETURN_NEXT(funcctx, HeapTupleGetDatum(tuple));
 }
 

Original file line number	Diff line number	Diff line change
`@@ -460,6 +460,7 @@ MtmAdjustOldestXid(TransactionId xid)`
`460`	`460`	`MtmTransState ts = (MtmTransState)hash_search(MtmXid2State, &xid, HASH_FIND, NULL);`
`461`	`461`	`MTM_LOG2("%d: MtmAdjustOldestXid(%d): snapshot=%ld, csn=%ld, status=%d", MyProcPid, xid, ts != NULL ? ts->snapshot : 0, ts != NULL ? ts->csn : 0, ts != NULL ? ts->status : -1);`
`462`	`462`	`Mtm->gcCount = 0;`
	`463`	`+`
`463`	`464`	`if (ts != NULL) {`
`464`	`465`	`oldestSnapshot = ts->snapshot;`
`465`	`466`	`Mtm->nodes[MtmNodeId-1].oldestSnapshot = oldestSnapshot;`
`@@ -486,6 +487,7 @@ MtmAdjustOldestXid(TransactionId xid)`
`486`	`487`	`}`
`487`	`488`	`}`
`488`	`489`	`}`
	`490`	`+`
`489`	`491`	`if (MtmUseDtm)`
`490`	`492`	`{`
`491`	`493`	`if (prev != NULL) {`
`@@ -2536,7 +2538,6 @@ mtm_get_cluster_info(PG_FUNCTION_ARGS)`
`2536`	`2538`	`tuple = BuildTupleFromCStrings(funcctx->attinmeta, values);`
`2537`	`2539`	`PQclear(result);`
`2538`	`2540`	`PQfinish(conn);`
`2539`		`- usrfctx->nodeId += 1;`
`2540`	`2541`	`SRF_RETURN_NEXT(funcctx, HeapTupleGetDatum(tuple));`
`2541`	`2542`	`}`
`2542`	`2543`