> Gavin Sherry <swm@linuxworld.com.au> writes:

bmomjian · bmomjian · commit 479a8fd69e7e · 2005-08-12T21:20:24.000Z
&gt; &gt; I ran across this yesterday on HEAD:
&gt;
&gt; &gt; template1=# grant select on foo, foo to swm;
&gt; &gt; ERROR:  tuple already updated by self
&gt;
&gt; Seems to fail similarly in every version back to 7.2; probably further,
&gt; but that's all I have running at the moment.
&gt;
&gt; &gt; We could do away with the error by producing a unique list of object names
&gt; &gt; -- but that would impose an extra cost on the common case.
&gt;
&gt; CommandCounterIncrement in the GRANT loop would be easier, likely.
&gt; I'm having a hard time getting excited about it though...

Yeah, its not that exciting but that error message would throw your
average user.

I've attached a patch which calls CommandCounterIncrement() in each of the
grant loops.

Gavin Sherry
diff --git a/src/backend/catalog/aclchk.c b/src/backend/catalog/aclchk.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/catalog/aclchk.c,v 1.116 2005/07/26 16:38:26 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/catalog/aclchk.c,v 1.117 2005/08/12 21:20:24 momjian Exp $
  *
  * NOTES
  *	  See acl.h.
@@ -388,6 +388,9 @@ ExecuteGrantStmt_Relation(GrantStmt *stmt)
 		pfree(new_acl);
 
 		heap_close(relation, RowExclusiveLock);
+
+		/* prevent error when processing duplicate objects */
+		CommandCounterIncrement();
 	}
 }
 
@@ -565,6 +568,9 @@ ExecuteGrantStmt_Database(GrantStmt *stmt)
 		heap_endscan(scan);
 
 		heap_close(relation, RowExclusiveLock);
+
+		/* prevent error when processing duplicate objects */
+		CommandCounterIncrement();
 	}
 }
 
@@ -738,6 +744,9 @@ ExecuteGrantStmt_Function(GrantStmt *stmt)
 		pfree(new_acl);
 
 		heap_close(relation, RowExclusiveLock);
+
+		/* prevent error when processing duplicate objects */
+		CommandCounterIncrement();
 	}
 }
 
@@ -920,6 +929,9 @@ ExecuteGrantStmt_Language(GrantStmt *stmt)
 		pfree(new_acl);
 
 		heap_close(relation, RowExclusiveLock);
+
+		/* prevent error when processing duplicate objects */
+		CommandCounterIncrement();
 	}
 }
 
@@ -1093,6 +1105,9 @@ ExecuteGrantStmt_Namespace(GrantStmt *stmt)
 		pfree(new_acl);
 
 		heap_close(relation, RowExclusiveLock);
+
+		/* prevent error when processing duplicate objects */
+		CommandCounterIncrement();
 	}
 }
 
@@ -1269,6 +1284,9 @@ ExecuteGrantStmt_Tablespace(GrantStmt *stmt)
 
 		heap_endscan(scan);
 		heap_close(relation, RowExclusiveLock);
+
+		/* prevent error when processing duplicate objects */
+		CommandCounterIncrement();
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/catalog/aclchk.c,v 1.116 2005/07/26 16:38:26 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/catalog/aclchk.c,v 1.117 2005/08/12 21:20:24 momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`* NOTES`
`14`	`14`	`* See acl.h.`
`@@ -388,6 +388,9 @@ ExecuteGrantStmt_Relation(GrantStmt *stmt)`
`388`	`388`	`pfree(new_acl);`
`389`	`389`
`390`	`390`	`heap_close(relation, RowExclusiveLock);`
	`391`	`+`
	`392`	`+ /* prevent error when processing duplicate objects */`
	`393`	`+ CommandCounterIncrement();`
`391`	`394`	`}`
`392`	`395`	`}`
`393`	`396`
`@@ -565,6 +568,9 @@ ExecuteGrantStmt_Database(GrantStmt *stmt)`
`565`	`568`	`heap_endscan(scan);`
`566`	`569`
`567`	`570`	`heap_close(relation, RowExclusiveLock);`
	`571`	`+`
	`572`	`+ /* prevent error when processing duplicate objects */`
	`573`	`+ CommandCounterIncrement();`
`568`	`574`	`}`
`569`	`575`	`}`
`570`	`576`
`@@ -738,6 +744,9 @@ ExecuteGrantStmt_Function(GrantStmt *stmt)`
`738`	`744`	`pfree(new_acl);`
`739`	`745`
`740`	`746`	`heap_close(relation, RowExclusiveLock);`
	`747`	`+`
	`748`	`+ /* prevent error when processing duplicate objects */`
	`749`	`+ CommandCounterIncrement();`
`741`	`750`	`}`
`742`	`751`	`}`
`743`	`752`
`@@ -920,6 +929,9 @@ ExecuteGrantStmt_Language(GrantStmt *stmt)`
`920`	`929`	`pfree(new_acl);`
`921`	`930`
`922`	`931`	`heap_close(relation, RowExclusiveLock);`
	`932`	`+`
	`933`	`+ /* prevent error when processing duplicate objects */`
	`934`	`+ CommandCounterIncrement();`
`923`	`935`	`}`
`924`	`936`	`}`
`925`	`937`
`@@ -1093,6 +1105,9 @@ ExecuteGrantStmt_Namespace(GrantStmt *stmt)`
`1093`	`1105`	`pfree(new_acl);`
`1094`	`1106`
`1095`	`1107`	`heap_close(relation, RowExclusiveLock);`
	`1108`	`+`
	`1109`	`+ /* prevent error when processing duplicate objects */`
	`1110`	`+ CommandCounterIncrement();`
`1096`	`1111`	`}`
`1097`	`1112`	`}`
`1098`	`1113`
`@@ -1269,6 +1284,9 @@ ExecuteGrantStmt_Tablespace(GrantStmt *stmt)`
`1269`	`1284`
`1270`	`1285`	`heap_endscan(scan);`
`1271`	`1286`	`heap_close(relation, RowExclusiveLock);`
	`1287`	`+`
	`1288`	`+ /* prevent error when processing duplicate objects */`
	`1289`	`+ CommandCounterIncrement();`
`1272`	`1290`	`}`
`1273`	`1291`	`}`
`1274`	`1292`