Mention that resetting the timeout may be wrong on select retry.

bmomjian · bmomjian · commit 4a513ab07f96 · 2002-10-14T18:11:17.000Z
diff --git a/src/interfaces/libpq/fe-misc.c b/src/interfaces/libpq/fe-misc.c
@@ -25,7 +25,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-misc.c,v 1.82 2002/10/14 17:33:08 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-misc.c,v 1.83 2002/10/14 18:11:17 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -824,7 +824,12 @@ pqWaitTimed(int forRead, int forWrite, PGconn *conn, const struct timeval *timeo
 		{
 			/*
 			 * 	select() may modify timeout argument on some platforms so
-			 *	use copy
+			 *	use copy.
+			 *	XXX Do we really want to do that?  If select() returns
+			 *	the number of seconds remaining, we are resetting
+			 *	the timeout to its original value.  This will yeild
+			 *	incorrect timings when select() is interrupted.
+			 *	bjm 2002-10-14
 			 */
 			tmp_timeout = *timeout;
 			ptmp_timeout = &tmp_timeout;

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@`
`25`	`25`	`*`
`26`	`26`	`*`
`27`	`27`	`* IDENTIFICATION`
`28`		`- * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-misc.c,v 1.82 2002/10/14 17:33:08 momjian Exp $`
	`28`	`+ * $Header: /cvsroot/pgsql/src/interfaces/libpq/fe-misc.c,v 1.83 2002/10/14 18:11:17 momjian Exp $`
`29`	`29`	`*`
`30`	`30`	`*-------------------------------------------------------------------------`
`31`	`31`	`*/`
`@@ -824,7 +824,12 @@ pqWaitTimed(int forRead, int forWrite, PGconn conn, const struct timeval timeo`
`824`	`824`	`{`
`825`	`825`	`/*`
`826`	`826`	`* select() may modify timeout argument on some platforms so`
`827`		`- * use copy`
	`827`	`+ * use copy.`
	`828`	`+ * XXX Do we really want to do that? If select() returns`
	`829`	`+ * the number of seconds remaining, we are resetting`
	`830`	`+ * the timeout to its original value. This will yeild`
	`831`	`+ * incorrect timings when select() is interrupted.`
	`832`	`+ * bjm 2002-10-14`
`828`	`833`	`*/`
`829`	`834`	`tmp_timeout = *timeout;`
`830`	`835`	`ptmp_timeout = &tmp_timeout;`