>> Hm. I'd sort of expect the "z" to become both the table and column

bmomjian · bmomjian · commit 4f63e11646da · 2002-08-06T05:34:10.000Z
&gt;&gt; alias in this case.  What do you think?
&gt;
&gt; I guess that would make sense. I'll make a separate patch just for
that
&gt; change if that's OK.
&gt;

Simple change -- patch attached.

test=# select * from myfoo1() as z;
  z
----
   1
   2
   3
(3 rows)

Joe Conway
diff --git a/src/backend/parser/parse_relation.c b/src/backend/parser/parse_relation.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_relation.c,v 1.74 2002/08/06 05:33:29 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_relation.c,v 1.75 2002/08/06 05:34:10 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -807,7 +807,7 @@ addRangeTableEntryForFunction(ParseState *pstate,
 			elog(ERROR, "Too many column aliases specified for function %s",
 				 funcname);
 		if (numaliases == 0)
-			eref->colnames = makeList1(makeString(funcname));
+			eref->colnames = makeList1(makeString(eref->aliasname));
 	}
 	else if (functyptype == 'p' && funcrettype == RECORDOID)
 	{

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/parser/parse_relation.c,v 1.74 2002/08/06 05:33:29 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/parser/parse_relation.c,v 1.75 2002/08/06 05:34:10 momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -807,7 +807,7 @@ addRangeTableEntryForFunction(ParseState *pstate,`
`807`	`807`	`elog(ERROR, "Too many column aliases specified for function %s",`
`808`	`808`	`funcname);`
`809`	`809`	`if (numaliases == 0)`
`810`		`- eref->colnames = makeList1(makeString(funcname));`
	`810`	`+ eref->colnames = makeList1(makeString(eref->aliasname));`
`811`	`811`	`}`
`812`	`812`	`else if (functyptype == 'p' && funcrettype == RECORDOID)`
`813`	`813`	`{`