Fix silly thinko in ALTER COLUMN TYPE. Check for finding expected

tglsfdc · tglsfdc · commit 55dc7faea2af · 2004-08-04T20:53:53.000Z
dependency was looking at wrong columns and so would always fail.
Was not exposed by regression tests because we are only testing cases
involving built-in (pinned) types and so no actual dependency entry
exists to be removed.
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.123 2004/08/01 20:30:48 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.124 2004/08/04 20:53:53 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -4888,8 +4888,8 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,
 		if (foundDep->deptype != DEPENDENCY_NORMAL)
 			elog(ERROR, "found unexpected dependency type '%c'",
 				 foundDep->deptype);
-		if (foundDep->classid != RelOid_pg_type ||
-			foundDep->objid != attTup->atttypid)
+		if (foundDep->refclassid != RelOid_pg_type ||
+			foundDep->refobjid != attTup->atttypid)
 			elog(ERROR, "found unexpected dependency for column");
 
 		simple_heap_delete(depRel, &depTup->t_self);

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.123 2004/08/01 20:30:48 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.124 2004/08/04 20:53:53 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -4888,8 +4888,8 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,`
`4888`	`4888`	`if (foundDep->deptype != DEPENDENCY_NORMAL)`
`4889`	`4889`	`elog(ERROR, "found unexpected dependency type '%c'",`
`4890`	`4890`	`foundDep->deptype);`
`4891`		`- if (foundDep->classid != RelOid_pg_type \|\|`
`4892`		`- foundDep->objid != attTup->atttypid)`
	`4891`	`+ if (foundDep->refclassid != RelOid_pg_type \|\|`
	`4892`	`+ foundDep->refobjid != attTup->atttypid)`
`4893`	`4893`	`elog(ERROR, "found unexpected dependency for column");`
`4894`	`4894`
`4895`	`4895`	`simple_heap_delete(depRel, &depTup->t_self);`