Treat exit code 128 (ERROR_WAIT_NO_CHILDREN) as non-fatal on Win32,

mhagander · mhagander · commit 594419e74ad4 · 2010-09-16T20:37:13.000Z
since it can happen when a process fails to start when the system
is under high load.

Per several bug reports and many peoples investigation.

Back-patch to 8.4, which is as far back as the "deadman-switch"
for shared memory access exists.
diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c
@@ -37,7 +37,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.615 2010/07/20 00:47:52 rhaas Exp $
+ *	  $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.616 2010/09/16 20:37:13 mha Exp $
  *
  * NOTES
  *
@@ -2588,6 +2588,19 @@ CleanupBackend(int pid,
 	 * assume everything is all right and proceed to remove the backend from
 	 * the active backend list.
 	 */
+#ifdef WIN32
+	/*
+	 * On win32, also treat ERROR_WAIT_NO_CHILDREN (128) as nonfatal
+	 * case, since that sometimes happens under load when the process fails
+	 * to start properly (long before it starts using shared memory).
+	 */
+	if (exitstatus == ERROR_WAIT_NO_CHILDREN)
+	{
+		LogChildExit(LOG, _("server process"), pid, exitstatus);
+		exitstatus = 0;
+	}
+#endif
+
 	if (!EXIT_STATUS_0(exitstatus) && !EXIT_STATUS_1(exitstatus))
 	{
 		HandleChildCrash(pid, exitstatus, _("server process"));

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@`
`37`	`37`	`*`
`38`	`38`	`*`
`39`	`39`	`* IDENTIFICATION`
`40`		`- * $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.615 2010/07/20 00:47:52 rhaas Exp $`
	`40`	`+ * $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.616 2010/09/16 20:37:13 mha Exp $`
`41`	`41`	`*`
`42`	`42`	`* NOTES`
`43`	`43`	`*`
`@@ -2588,6 +2588,19 @@ CleanupBackend(int pid,`
`2588`	`2588`	`* assume everything is all right and proceed to remove the backend from`
`2589`	`2589`	`* the active backend list.`
`2590`	`2590`	`*/`
	`2591`	`+#ifdef WIN32`
	`2592`	`+ /*`
	`2593`	`+ * On win32, also treat ERROR_WAIT_NO_CHILDREN (128) as nonfatal`
	`2594`	`+ * case, since that sometimes happens under load when the process fails`
	`2595`	`+ * to start properly (long before it starts using shared memory).`
	`2596`	`+ */`
	`2597`	`+ if (exitstatus == ERROR_WAIT_NO_CHILDREN)`
	`2598`	`+ {`
	`2599`	`+ LogChildExit(LOG, _("server process"), pid, exitstatus);`
	`2600`	`+ exitstatus = 0;`
	`2601`	`+ }`
	`2602`	`+#endif`
	`2603`	`+`
`2591`	`2604`	`if (!EXIT_STATUS_0(exitstatus) && !EXIT_STATUS_1(exitstatus))`
`2592`	`2605`	`{`
`2593`	`2606`	`HandleChildCrash(pid, exitstatus, _("server process"));`