Add error propagation under creating new partition;

Maksim Milyutin · Maksim Milyutin · commit 59778f567d34 · 2017-02-08T20:03:23.000+03:00
add test for the case of deleting callback function under existing the
referencies to it on new partitions
diff --git a/expected/pathman_callbacks.out b/expected/pathman_callbacks.out
@@ -129,6 +129,39 @@ WARNING:  callback arg: {"parent": "abc", "parttype": "2", "partition": "abc_2",
 
 DROP TABLE abc CASCADE;
 NOTICE:  drop cascades to 2 other objects
+/* test the temprary deletion of callback function */
+CREATE TABLE abc(a serial, b int);
+SELECT set_init_callback('abc',
+						 'callbacks.abc_on_part_created_callback');
+ set_init_callback 
+-------------------
+ 
+(1 row)
+
+SELECT create_range_partitions('abc', 'a', 1, 100, 2);
+WARNING:  callback arg: {"parent": "abc", "parttype": "2", "partition": "abc_1", "range_max": "101", "range_min": "1", "parent_schema": "public", "partition_schema": "public"}
+WARNING:  callback arg: {"parent": "abc", "parttype": "2", "partition": "abc_2", "range_max": "201", "range_min": "101", "parent_schema": "public", "partition_schema": "public"}
+ create_range_partitions 
+-------------------------
+                       2
+(1 row)
+
+INSERT INTO abc VALUES (201, 0);
+WARNING:  callback arg: {"parent": "abc", "parttype": "2", "partition": "abc_3", "range_max": "301", "range_min": "201", "parent_schema": "public", "partition_schema": "public"}
+DROP FUNCTION callbacks.abc_on_part_created_callback(jsonb);
+INSERT INTO abc VALUES (301, 0);
+ERROR:  create_partitions_internal(): callback function "]callbacks.abc_on_part_created_callback(jsonb)" doesn't exist
+CREATE OR REPLACE FUNCTION callbacks.abc_on_part_created_callback(
+	args JSONB)
+RETURNS VOID AS $$
+BEGIN
+	RAISE WARNING 'callback arg: %', args::TEXT;
+END
+$$ language plpgsql;
+INSERT INTO abc VALUES (301, 0);
+WARNING:  callback arg: {"parent": "abc", "parttype": "2", "partition": "abc_5", "range_max": "401", "range_min": "301", "parent_schema": "public", "partition_schema": "public"}
+DROP TABLE abc CASCADE;
+NOTICE:  drop cascades to 4 other objects
 DROP SCHEMA callbacks CASCADE;
 NOTICE:  drop cascades to 2 other objects
 DROP EXTENSION pg_pathman CASCADE;
diff --git a/sql/pathman_callbacks.sql b/sql/pathman_callbacks.sql
@@ -53,5 +53,26 @@ SELECT create_range_partitions('abc', 'a', 1, 100, 2);
 
 DROP TABLE abc CASCADE;
 
+/* test the temprary deletion of callback function */
+CREATE TABLE abc(a serial, b int);
+SELECT set_init_callback('abc',
+						 'callbacks.abc_on_part_created_callback');
+SELECT create_range_partitions('abc', 'a', 1, 100, 2);
+
+INSERT INTO abc VALUES (201, 0);
+DROP FUNCTION callbacks.abc_on_part_created_callback(jsonb);
+INSERT INTO abc VALUES (301, 0);
+CREATE OR REPLACE FUNCTION callbacks.abc_on_part_created_callback(
+	args JSONB)
+RETURNS VOID AS $$
+BEGIN
+	RAISE WARNING 'callback arg: %', args::TEXT;
+END
+$$ language plpgsql;
+INSERT INTO abc VALUES (301, 0);
+
+DROP TABLE abc CASCADE;
+
+
 DROP SCHEMA callbacks CASCADE;
 DROP EXTENSION pg_pathman CASCADE;
diff --git a/src/partition_creation.c b/src/partition_creation.c
@@ -405,8 +405,14 @@ create_partitions_for_value_internal(Oid relid, Datum value, Oid value_type)
 		edata = CopyErrorData();
 		FlushErrorState();
 
-		elog(LOG, "create_partitions_internal(): %s [%u]",
-			 edata->message, MyProcPid);
+		if (IsBackgroundWorker)
+			ereport(LOG,
+					(errmsg("create_partitions_internal(): %s [%u]", edata->message, MyProcPid),
+					 (edata->detail) ? errdetail("%s", edata->detail) : 0));
+		else
+			ereport(ERROR,
+					(errmsg("create_partitions_internal(): %s", edata->message),
+					 (edata->detail) ? errdetail("%s", edata->detail) : 0));
 
 		FreeErrorData(edata);
 
