Add comment about rationale for continuing to use C library functions

tglsfdc · tglsfdc · commit 5ca40c5d31bc · 2004-06-21T14:12:38.000Z
instead of src/timezone for timestamping log entries.
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
@@ -37,7 +37,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.140 2004/06/03 02:08:04 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.141 2004/06/21 14:12:38 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1214,6 +1214,16 @@ log_line_prefix(StringInfo buf)
 				break;
 			case 't':
 				{
+					/*
+					 * Note: for %t and %s we deliberately use the C library's
+					 * strftime/localtime, and not the equivalent functions
+					 * from src/timezone.  This ensures that all backends
+					 * will report log entries in the same timezone, namely
+					 * whatever C-library setting they inherit from the
+					 * postmaster.  If we used src/timezone then local
+					 * settings of the TimeZone GUC variable would confuse
+					 * the log.
+					 */
 					time_t stamp_time = time(NULL);
 					char strfbuf[128];
 

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@`
`37`	`37`	`*`
`38`	`38`	`*`
`39`	`39`	`* IDENTIFICATION`
`40`		`- * $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.140 2004/06/03 02:08:04 tgl Exp $`
	`40`	`+ * $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.141 2004/06/21 14:12:38 tgl Exp $`
`41`	`41`	`*`
`42`	`42`	`*-------------------------------------------------------------------------`
`43`	`43`	`*/`
`@@ -1214,6 +1214,16 @@ log_line_prefix(StringInfo buf)`
`1214`	`1214`	`break;`
`1215`	`1215`	`case 't':`
`1216`	`1216`	`{`
	`1217`	`+ /*`
	`1218`	`+ * Note: for %t and %s we deliberately use the C library's`
	`1219`	`+ * strftime/localtime, and not the equivalent functions`
	`1220`	`+ * from src/timezone. This ensures that all backends`
	`1221`	`+ * will report log entries in the same timezone, namely`
	`1222`	`+ * whatever C-library setting they inherit from the`
	`1223`	`+ * postmaster. If we used src/timezone then local`
	`1224`	`+ * settings of the TimeZone GUC variable would confuse`
	`1225`	`+ * the log.`
	`1226`	`+ */`
`1217`	`1227`	`time_t stamp_time = time(NULL);`
`1218`	`1228`	`char strfbuf[128];`
`1219`	`1229`