Skip to content

Commit 5f3499b

Browse files
committed
postgres_fdw: Remove schema-qualification from cast to text.
As pointed out by Ashutosh Bapat, the header comments for this file say that schema-qualification is needed for all and only those types outside pg_catalog. pg_catalog.text is not outside pg_catalog.
1 parent 4f9f495 commit 5f3499b

File tree

2 files changed

+26
-26
lines changed

2 files changed

+26
-26
lines changed

contrib/postgres_fdw/deparse.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1601,7 +1601,7 @@ deparseColumnRef(StringInfo buf, int varno, int varattno, PlannerInfo *root,
16011601
{
16021602
appendStringInfoString(buf, "CASE WHEN (");
16031603
ADD_REL_QUALIFIER(buf, varno);
1604-
appendStringInfo(buf, "*)::pg_catalog.text IS NOT NULL THEN %u END", fetchval);
1604+
appendStringInfo(buf, "*)::text IS NOT NULL THEN %u END", fetchval);
16051605
}
16061606
else
16071607
appendStringInfo(buf, "%u", fetchval);
@@ -1645,7 +1645,7 @@ deparseColumnRef(StringInfo buf, int varno, int varattno, PlannerInfo *root,
16451645
{
16461646
appendStringInfoString(buf, "CASE WHEN (");
16471647
ADD_REL_QUALIFIER(buf, varno);
1648-
appendStringInfo(buf, "*)::pg_catalog.text IS NOT NULL THEN ");
1648+
appendStringInfo(buf, "*)::text IS NOT NULL THEN ");
16491649
}
16501650

16511651
appendStringInfoString(buf, "ROW(");

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy