Skip to content

Commit 5f6d735

Browse files
author
Neil Conway
committed
Attached patch fixes two problems:
1) gendef works from inside visual studio - use a tempfile instead of redirection, because for some reason you can't redirect dumpbin from inside (patch from Joachim Wieland) 2) gendef must process only *.obj, or you get weird errors in some build scenarios when it tries to process a logfile Magnus Hagander
1 parent 840df51 commit 5f6d735

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/tools/msvc/gendef.pl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@
1010

1111
print "Generating $defname.DEF from directory $ARGV[0]\n";
1212

13-
while (<$ARGV[0]/*>) {
13+
while (<$ARGV[0]/*.obj>) {
1414
print ".";
15-
open(F,"dumpbin /symbols $_|") || die "Could not open $_\n";
15+
system("dumpbin /symbols /out:symbols.out $_ >NUL") && die "Could not call dumpbin";
16+
open(F, "<symbols.out") || die "Could not open symbols.out for $_\n";
1617
while (<F>) {
1718
s/\(\)//g;
1819
next unless /^\d/;
@@ -31,6 +32,7 @@
3132
push @def, $pieces[6];
3233
}
3334
close(F);
35+
unlink("symbols.out");
3436
}
3537
print "\n";
3638

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy