Minor sync rep corrections.

robertmhaas · robertmhaas · commit 64360987953e · 2011-03-10T14:57:02.000-05:00
Fujii Masao, with a bit of additional wordsmithing by me.
diff --git a/src/backend/replication/syncrep.c b/src/backend/replication/syncrep.c
@@ -447,9 +447,9 @@ SyncRepGetStandbyPriority(void)
 }
 
 /*
- * Walk queue from head setting setting the state of any backends that
- * need to be woken, remove them from the queue and then wake them.
- * Set all = true to wake whole queue, or just up to LSN.
+ * Walk queue from head.  Set the state of any backends that need to be woken,
+ * remove them from the queue, and then wake them.  Pass all = true to wake
+ * whole queue; otherwise, just wake up to the walsender's LSN.
  *
  * Must hold SyncRepLock.
  */
diff --git a/src/backend/storage/ipc/shmqueue.c b/src/backend/storage/ipc/shmqueue.c
@@ -157,7 +157,7 @@ SHMQueueNext(const SHM_QUEUE *queue, const SHM_QUEUE *curElem, Size linkOffset)
 /*--------------------
  * SHMQueuePrev -- Get the previous element from a queue
  *
- * Same as SHMQueueNext, just starting at tail and moving towards head
+ * Same as SHMQueueNext, just starting at tail and moving towards head.
  * All other comments and usage applies.
  */
 Pointer
diff --git a/src/include/replication/syncrep.h b/src/include/replication/syncrep.h
@@ -29,7 +29,6 @@
 
 /* user-settable parameters for synchronous replication */
 extern bool sync_rep_mode;
-extern int 	sync_rep_timeout;
 extern char *SyncRepStandbyNames;
 
 /* called by user backend */
@@ -44,6 +43,6 @@ extern void SyncRepReleaseWaiters(void);
 
 /* called by various procs */
 extern int SyncRepWakeQueue(bool all);
-const char *assign_synchronous_standby_names(const char *newval, bool doit, GucSource source);
+extern const char *assign_synchronous_standby_names(const char *newval, bool doit, GucSource source);
 
 #endif   /* _SYNCREP_H */

Original file line number	Diff line number	Diff line change
`@@ -447,9 +447,9 @@ SyncRepGetStandbyPriority(void)`
`447`	`447`	`}`
`448`	`448`
`449`	`449`	`/*`
`450`		`- * Walk queue from head setting setting the state of any backends that`
`451`		`- * need to be woken, remove them from the queue and then wake them.`
`452`		`- * Set all = true to wake whole queue, or just up to LSN.`
	`450`	`+ * Walk queue from head. Set the state of any backends that need to be woken,`
	`451`	`+ * remove them from the queue, and then wake them. Pass all = true to wake`
	`452`	`+ * whole queue; otherwise, just wake up to the walsender's LSN.`
`453`	`453`	`*`
`454`	`454`	`* Must hold SyncRepLock.`
`455`	`455`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ SHMQueueNext(const SHM_QUEUE queue, const SHM_QUEUE curElem, Size linkOffset)`
`157`	`157`	`/*--------------------`
`158`	`158`	`* SHMQueuePrev -- Get the previous element from a queue`
`159`	`159`	`*`
`160`		`- * Same as SHMQueueNext, just starting at tail and moving towards head`
	`160`	`+ * Same as SHMQueueNext, just starting at tail and moving towards head.`
`161`	`161`	`* All other comments and usage applies.`
`162`	`162`	`*/`
`163`	`163`	`Pointer`