Fix session-lifespan memory leak when a plperl function is redefined:

tglsfdc · tglsfdc · commit 67ec9adaf13f · 2009-11-29T21:02:16.000Z
we have to tell Perl it can release its compiled copy of the function
text.  Noted by Alexey Klyukin.

Back-patch to 8.2 --- the problem exists further back, but this patch
won't work without modification, and it's probably not worth the trouble.
diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c
@@ -1,7 +1,7 @@
 /**********************************************************************
  * plperl.c - perl as a procedural language for PostgreSQL
  *
- *	  $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.154 2009/11/29 03:02:27 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.155 2009/11/29 21:02:16 tgl Exp $
  *
  **********************************************************************/
 
@@ -1651,11 +1651,13 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)
 
 		if (!uptodate)
 		{
+			hash_search(plperl_proc_hash, internal_proname,
+						HASH_REMOVE, NULL);
+			if (prodesc->reference)
+				SvREFCNT_dec(prodesc->reference);
 			free(prodesc->proname);
 			free(prodesc);
 			prodesc = NULL;
-			hash_search(plperl_proc_hash, internal_proname,
-						HASH_REMOVE, NULL);
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/**********************************************************************`
`2`	`2`	`* plperl.c - perl as a procedural language for PostgreSQL`
`3`	`3`	`*`
`4`		`- * $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.154 2009/11/29 03:02:27 tgl Exp $`
	`4`	`+ * $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.155 2009/11/29 21:02:16 tgl Exp $`
`5`	`5`	`*`
`6`	`6`	`**********************************************************************/`
`7`	`7`
`@@ -1651,11 +1651,13 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)`
`1651`	`1651`
`1652`	`1652`	`if (!uptodate)`
`1653`	`1653`	`{`
	`1654`	`+ hash_search(plperl_proc_hash, internal_proname,`
	`1655`	`+ HASH_REMOVE, NULL);`
	`1656`	`+ if (prodesc->reference)`
	`1657`	`+ SvREFCNT_dec(prodesc->reference);`
`1654`	`1658`	`free(prodesc->proname);`
`1655`	`1659`	`free(prodesc);`
`1656`	`1660`	`prodesc = NULL;`
`1657`		`- hash_search(plperl_proc_hash, internal_proname,`
`1658`		`- HASH_REMOVE, NULL);`
`1659`	`1661`	`}`
`1660`	`1662`	`}`
`1661`	`1663`