Fix typo that caused equalTriggerDescs() to return false in cases where

tglsfdc · tglsfdc · commit 685a66cdfe07 · 2002-01-15T16:52:47.000Z
the two trigger sets were logically equal, but not in the same order.
Caught by Holger Krug (hkrug@rationalizer.com).
diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/commands/trigger.c,v 1.100 2002/01/03 23:21:23 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/commands/trigger.c,v 1.101 2002/01/15 16:52:47 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -805,7 +805,7 @@ equalTriggerDescs(TriggerDesc *trigdesc1, TriggerDesc *trigdesc2)
 			 */
 			for (j = 0; j < trigdesc2->numtriggers; j++)
 			{
-				trig2 = trigdesc2->triggers + i;
+				trig2 = trigdesc2->triggers + j;
 				if (trig1->tgoid == trig2->tgoid)
 					break;
 			}

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1994, Regents of the University of California`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/commands/trigger.c,v 1.100 2002/01/03 23:21:23 tgl Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/trigger.c,v 1.101 2002/01/15 16:52:47 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -805,7 +805,7 @@ equalTriggerDescs(TriggerDesc trigdesc1, TriggerDesc trigdesc2)`
`805`	`805`	`*/`
`806`	`806`	`for (j = 0; j < trigdesc2->numtriggers; j++)`
`807`	`807`	`{`
`808`		`- trig2 = trigdesc2->triggers + i;`
	`808`	`+ trig2 = trigdesc2->triggers + j;`
`809`	`809`	`if (trig1->tgoid == trig2->tgoid)`
`810`	`810`	`break;`
`811`	`811`	`}`