pg_dump/t/002: append terminating semicolon to SQL commands

alvherre · alvherre · commit 698923d6588e · 2017-05-03T15:12:09.000-03:00
It's easy to overlook the need for one, and its lack is annoying for the next developer wanting to create a new test. Rather than expect every individual command to add the semicolon, just append one automatically. Discussion: http://postgr.es/m/20170503172746.rwftidszir67sgk7@alvherre.pgsql
diff --git a/src/bin/pg_dump/t/002_pg_dump.pl b/src/bin/pg_dump/t/002_pg_dump.pl
@@ -6414,7 +6414,8 @@
 			next;
 		}
 
-		$create_sql .= $tests{$test}->{create_sql};
+		# Add terminating semicolon
+		$create_sql .= $tests{$test}->{create_sql} . ";";
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -6414,7 +6414,8 @@`
`6414`	`6414`	`next;`
`6415`	`6415`	`}`
`6416`	`6416`
`6417`		`- $create_sql .= $tests{$test}->{create_sql};`
	`6417`	`+ # Add terminating semicolon`
	`6418`	`+ $create_sql .= $tests{$test}->{create_sql} . ";";`
`6418`	`6419`	`}`
`6419`	`6420`	`}`
`6420`	`6421`