Add connection messages for streaming replication. log_connections

simonat2ndQuadrant · simonat2ndQuadrant · commit 6a771d1d367d · 2010-03-19T19:19:38.000Z
was broken for a replication connection and no messages were
displayed on either standby or primary, at any debug level.
Connection messages needed to diagnose session drop/reconnect
events. Use LOG mode for now, discuss lowering in later releases.
diff --git a/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c b/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
@@ -10,7 +10,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c,v 1.6 2010/03/19 17:51:42 sriggs Exp $
+ *	  $PostgreSQL: pgsql/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c,v 1.7 2010/03/19 19:19:38 sriggs Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -157,6 +157,8 @@ libpqrcv_connect(char *conninfo, XLogRecPtr startpoint)
 	PQclear(res);
 
 	justconnected = true;
+	ereport(LOG,
+			(errmsg("streaming replication successfully connected to primary")));
 
 	return true;
 }
diff --git a/src/backend/utils/init/postinit.c b/src/backend/utils/init/postinit.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/init/postinit.c,v 1.204 2010/02/26 02:01:13 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/init/postinit.c,v 1.205 2010/03/19 19:19:38 sriggs Exp $
  *
  *
  *-------------------------------------------------------------------------
@@ -217,7 +217,14 @@ PerformAuthentication(Port *port)
 	if (!disable_sig_alarm(true))
 		elog(FATAL, "could not disable timer for authorization timeout");
 
-	if (Log_connections)
+	/*
+	 * Log connection for streaming replication even if Log_connections disabled.
+	 */
+	if (am_walsender)
+		ereport(LOG,
+				(errmsg("connection authorized: user=%s database=replication",
+						port->user_name)));
+	else if (Log_connections)
 		ereport(LOG,
 				(errmsg("connection authorized: user=%s database=%s",
 						port->user_name, port->database_name)));

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`*`
`11`	`11`	`*`
`12`	`12`	`* IDENTIFICATION`
`13`		`- * $PostgreSQL: pgsql/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c,v 1.6 2010/03/19 17:51:42 sriggs Exp $`
	`13`	`+ * $PostgreSQL: pgsql/src/backend/replication/libpqwalreceiver/libpqwalreceiver.c,v 1.7 2010/03/19 19:19:38 sriggs Exp $`
`14`	`14`	`*`
`15`	`15`	`*-------------------------------------------------------------------------`
`16`	`16`	`*/`
`@@ -157,6 +157,8 @@ libpqrcv_connect(char *conninfo, XLogRecPtr startpoint)`
`157`	`157`	`PQclear(res);`
`158`	`158`
`159`	`159`	`justconnected = true;`
	`160`	`+ ereport(LOG,`
	`161`	`+ (errmsg("streaming replication successfully connected to primary")));`
`160`	`162`
`161`	`163`	`return true;`
`162`	`164`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/utils/init/postinit.c,v 1.204 2010/02/26 02:01:13 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/utils/init/postinit.c,v 1.205 2010/03/19 19:19:38 sriggs Exp $`
`12`	`12`	`*`
`13`	`13`	`*`
`14`	`14`	`*-------------------------------------------------------------------------`
`@@ -217,7 +217,14 @@ PerformAuthentication(Port *port)`
`217`	`217`	`if (!disable_sig_alarm(true))`
`218`	`218`	`elog(FATAL, "could not disable timer for authorization timeout");`
`219`	`219`
`220`		`- if (Log_connections)`
	`220`	`+ /*`
	`221`	`+ * Log connection for streaming replication even if Log_connections disabled.`
	`222`	`+ */`
	`223`	`+ if (am_walsender)`
	`224`	`+ ereport(LOG,`
	`225`	`+ (errmsg("connection authorized: user=%s database=replication",`
	`226`	`+ port->user_name)));`
	`227`	`+ else if (Log_connections)`
`221`	`228`	`ereport(LOG,`
`222`	`229`	`(errmsg("connection authorized: user=%s database=%s",`
`223`	`230`	`port->user_name, port->database_name)));`