Fix pg_dump to not crash if -t or a similar switch is used to select a serial

tglsfdc · tglsfdc · commit 6ee2a3be4ab1 · 2007-04-16T18:42:10.000Z
sequence for dumping without also selecting its owning table.  Make it not try
to emit ALTER SEQUENCE OWNED BY in this situation.
Per report from Michael Nolan.
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -12,7 +12,7 @@
  *	by PostgreSQL
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.466 2007/04/02 03:49:39 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.467 2007/04/16 18:42:10 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -8654,8 +8654,8 @@ dumpSequence(Archive *fout, TableInfo *tbinfo)
 	 *
 	 * Add a CREATE SEQUENCE statement as part of a "schema" dump (use
 	 * last_val for start if called is false, else use min_val for start_val).
-	 * Also, if the sequence is owned by a column, add an ALTER SEQUENCE SET
-	 * OWNED command for it.
+	 * Also, if the sequence is owned by a column, add an ALTER SEQUENCE
+	 * OWNED BY command for it.
 	 *
 	 * Add a 'SETVAL(seq, last_val, iscalled)' as part of a "data" dump.
 	 */
@@ -8723,7 +8723,7 @@ dumpSequence(Archive *fout, TableInfo *tbinfo)
 		{
 			TableInfo  *owning_tab = findTableByOid(tbinfo->owning_tab);
 
-			if (owning_tab)
+			if (owning_tab && owning_tab->dobj.dump)
 			{
 				resetPQExpBuffer(query);
 				appendPQExpBuffer(query, "ALTER SEQUENCE %s",

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`* by PostgreSQL`
`13`	`13`	`*`
`14`	`14`	`* IDENTIFICATION`
`15`		`- * $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.466 2007/04/02 03:49:39 tgl Exp $`
	`15`	`+ * $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.467 2007/04/16 18:42:10 tgl Exp $`
`16`	`16`	`*`
`17`	`17`	`*-------------------------------------------------------------------------`
`18`	`18`	`*/`
`@@ -8654,8 +8654,8 @@ dumpSequence(Archive fout, TableInfo tbinfo)`
`8654`	`8654`	`*`
`8655`	`8655`	`* Add a CREATE SEQUENCE statement as part of a "schema" dump (use`
`8656`	`8656`	`* last_val for start if called is false, else use min_val for start_val).`
`8657`		`- * Also, if the sequence is owned by a column, add an ALTER SEQUENCE SET`
`8658`		`- * OWNED command for it.`
	`8657`	`+ * Also, if the sequence is owned by a column, add an ALTER SEQUENCE`
	`8658`	`+ * OWNED BY command for it.`
`8659`	`8659`	`*`
`8660`	`8660`	`* Add a 'SETVAL(seq, last_val, iscalled)' as part of a "data" dump.`
`8661`	`8661`	`*/`
`@@ -8723,7 +8723,7 @@ dumpSequence(Archive fout, TableInfo tbinfo)`
`8723`	`8723`	`{`
`8724`	`8724`	`TableInfo *owning_tab = findTableByOid(tbinfo->owning_tab);`
`8725`	`8725`
`8726`		`- if (owning_tab)`
	`8726`	`+ if (owning_tab && owning_tab->dobj.dump)`
`8727`	`8727`	`{`
`8728`	`8728`	`resetPQExpBuffer(query);`
`8729`	`8729`	`appendPQExpBuffer(query, "ALTER SEQUENCE %s",`