Fix incorrect comment about permissions checking being done in utility.c.

robertmhaas · robertmhaas · commit 70aedc0c55b6 · 2010-03-10T19:48:39.000Z
Noted while reviewing a patch from KaiGai Kohei.
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.327 2010/02/26 02:00:39 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.328 2010/03/10 19:48:39 rhaas Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1956,10 +1956,7 @@ renameatt(Oid myrelid,
 				 errmsg("cannot rename column of typed table")));
 
 	/*
-	 * permissions checking.  this would normally be done in utility.c, but
-	 * this particular routine is recursive.
-	 *
-	 * normally, only the owner of a class can change its schema.
+	 * permissions checking.  only the owner of a class can change its schema.
 	 */
 	if (!pg_class_ownercheck(myrelid, GetUserId()))
 		aclcheck_error(ACLCHECK_NOT_OWNER, ACL_KIND_CLASS,

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.327 2010/02/26 02:00:39 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.328 2010/03/10 19:48:39 rhaas Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -1956,10 +1956,7 @@ renameatt(Oid myrelid,`
`1956`	`1956`	`errmsg("cannot rename column of typed table")));`
`1957`	`1957`
`1958`	`1958`	`/*`
`1959`		`- * permissions checking. this would normally be done in utility.c, but`
`1960`		`- * this particular routine is recursive.`
`1961`		`- *`
`1962`		`- * normally, only the owner of a class can change its schema.`
	`1959`	`+ * permissions checking. only the owner of a class can change its schema.`
`1963`	`1960`	`*/`
`1964`	`1961`	`if (!pg_class_ownercheck(myrelid, GetUserId()))`
`1965`	`1962`	`aclcheck_error(ACLCHECK_NOT_OWNER, ACL_KIND_CLASS,`