Suppress compiler warnings in non-cassert builds.

tglsfdc · tglsfdc · commit 71e006f03131 · 2016-08-23T23:21:10.000-04:00
With Asserts off, these variables are set but never used, resulting
in warnings from pickier compilers.  Fix that with our standard solution.
Per report from Jeff Janes.
diff --git a/src/backend/access/gist/gistutil.c b/src/backend/access/gist/gistutil.c
@@ -852,7 +852,7 @@ gistproperty(Oid index_oid, int attno,
 			 bool *res, bool *isnull)
 {
 	HeapTuple	tuple;
-	Form_pg_index rd_index;
+	Form_pg_index rd_index PG_USED_FOR_ASSERTS_ONLY;
 	Form_pg_opclass rd_opclass;
 	Datum		datum;
 	bool		disnull;
diff --git a/src/backend/utils/adt/amutils.c b/src/backend/utils/adt/amutils.c
@@ -115,7 +115,7 @@ test_indoption(Oid relid, int attno, bool guard,
 			   bool *res)
 {
 	HeapTuple	tuple;
-	Form_pg_index rd_index;
+	Form_pg_index rd_index PG_USED_FOR_ASSERTS_ONLY;
 	Datum		datum;
 	bool		isnull;
 	int2vector *indoption;

Original file line number	Diff line number	Diff line change
`@@ -852,7 +852,7 @@ gistproperty(Oid index_oid, int attno,`
`852`	`852`	`bool res, bool isnull)`
`853`	`853`	`{`
`854`	`854`	`HeapTuple tuple;`
`855`		`- Form_pg_index rd_index;`
	`855`	`+ Form_pg_index rd_index PG_USED_FOR_ASSERTS_ONLY;`
`856`	`856`	`Form_pg_opclass rd_opclass;`
`857`	`857`	`Datum datum;`
`858`	`858`	`bool disnull;`
Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ test_indoption(Oid relid, int attno, bool guard,`
`115`	`115`	`bool *res)`
`116`	`116`	`{`
`117`	`117`	`HeapTuple tuple;`
`118`		`- Form_pg_index rd_index;`
	`118`	`+ Form_pg_index rd_index PG_USED_FOR_ASSERTS_ONLY;`
`119`	`119`	`Datum datum;`
`120`	`120`	`bool isnull;`
`121`	`121`	`int2vector *indoption;`