Add "break"s to make it clearer what will happen in a nested switch.

tglsfdc · tglsfdc · commit 766f7fd613ad · 2017-03-12T16:01:33.000-04:00
This could only matter if the guessed_type variable had a value that wasn't
a member of the PasswordType enum; but just in case, let's be sure that
control falls out to reach the elog(ERROR) at the end of the function.
Per gripe from Coverity.
diff --git a/src/backend/libpq/crypt.c b/src/backend/libpq/crypt.c
@@ -162,6 +162,7 @@ encrypt_password(PasswordType target_type, const char *role,
 				case PASSWORD_TYPE_MD5:
 					return pstrdup(password);
 			}
+			break;
 
 		case PASSWORD_TYPE_SCRAM:
 			switch (guessed_type)
@@ -178,6 +179,7 @@ encrypt_password(PasswordType target_type, const char *role,
 				case PASSWORD_TYPE_SCRAM:
 					return pstrdup(password);
 			}
+			break;
 	}
 
 	/*

Original file line number	Diff line number	Diff line change
`@@ -162,6 +162,7 @@ encrypt_password(PasswordType target_type, const char *role,`
`162`	`162`	`case PASSWORD_TYPE_MD5:`
`163`	`163`	`return pstrdup(password);`
`164`	`164`	`}`
	`165`	`+ break;`
`165`	`166`
`166`	`167`	`case PASSWORD_TYPE_SCRAM:`
`167`	`168`	`switch (guessed_type)`
`@@ -178,6 +179,7 @@ encrypt_password(PasswordType target_type, const char *role,`
`178`	`179`	`case PASSWORD_TYPE_SCRAM:`
`179`	`180`	`return pstrdup(password);`
`180`	`181`	`}`
	`182`	`+ break;`
`181`	`183`	`}`
`182`	`184`
`183`	`185`	`/*`