Fix seriously nasty memory leak in new TransactionIdIsInProgress code.

tglsfdc · tglsfdc · commit 77a436ba55de · 2004-07-01T03:13:05.000Z
diff --git a/src/backend/storage/ipc/sinval.c b/src/backend/storage/ipc/sinval.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/storage/ipc/sinval.c,v 1.65 2004/07/01 00:50:52 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/storage/ipc/sinval.c,v 1.66 2004/07/01 03:13:05 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -509,7 +509,6 @@ TransactionIdIsInProgress(TransactionId xid)
 
 			if (result)
 				break;
-
 		}
 	}
 
@@ -531,12 +530,18 @@ TransactionIdIsInProgress(TransactionId xid)
 		 * We don't care if it aborted, because if it did, we won't find
 		 * it in the array.
 		 */
-
 		for (i = 0; i < nxids; i++)
+		{
 			if (TransactionIdEquals(xids[i], xid))
-				return true;
+			{
+				result = true;
+				break;
+			}
+		}
 	}
 
+	pfree(xids);
+
 	return result;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/storage/ipc/sinval.c,v 1.65 2004/07/01 00:50:52 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/storage/ipc/sinval.c,v 1.66 2004/07/01 03:13:05 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -509,7 +509,6 @@ TransactionIdIsInProgress(TransactionId xid)`
`509`	`509`
`510`	`510`	`if (result)`
`511`	`511`	`break;`
`512`		`-`
`513`	`512`	`}`
`514`	`513`	`}`
`515`	`514`
`@@ -531,12 +530,18 @@ TransactionIdIsInProgress(TransactionId xid)`
`531`	`530`	`* We don't care if it aborted, because if it did, we won't find`
`532`	`531`	`* it in the array.`
`533`	`532`	`*/`
`534`		`-`
`535`	`533`	`for (i = 0; i < nxids; i++)`
	`534`	`+ {`
`536`	`535`	`if (TransactionIdEquals(xids[i], xid))`
`537`		`- return true;`
	`536`	`+ {`
	`537`	`+ result = true;`
	`538`	`+ break;`
	`539`	`+ }`
	`540`	`+ }`
`538`	`541`	`}`
`539`	`542`
	`543`	`+ pfree(xids);`
	`544`	`+`
`540`	`545`	`return result;`
`541`	`546`	`}`
`542`	`547`