PostgresNode: wrap correctly around port number range end

alvherre · alvherre · commit 7ac5d9b31637 · 2015-12-07T20:06:21.000-03:00
Per note from Tom Lane
diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm
@@ -321,7 +321,8 @@ sub get_new_node
 
 	while ($found == 0)
 	{
-		$port++;
+		# wrap correctly around range end
+		$port = 49152 if ++$port >= 65536;
 		print "# Checking for port $port\n";
 		if (!TestLib::run_log([ 'pg_isready', '-p', $port ]))
 		{

Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,8 @@ sub get_new_node`
`321`	`321`
`322`	`322`	`while ($found == 0)`
`323`	`323`	`{`
`324`		`- $port++;`
	`324`	`+ # wrap correctly around range end`
	`325`	`+ $port = 49152 if ++$port >= 65536;`
`325`	`326`	`print "# Checking for port $port\n";`
`326`	`327`	`if (!TestLib::run_log([ 'pg_isready', '-p', $port ]))`
`327`	`328`	`{`