fix warnings reported by clang-analyzer

funbringer · funbringer · commit 7c15a2a400c0 · 2016-09-15T20:24:45.000+03:00
diff --git a/src/copy_stmt_hooking.c b/src/copy_stmt_hooking.c
@@ -160,7 +160,6 @@ PathmanDoCopy(const CopyStmt *stmt, const char *queryString, uint64 *processed)
 	bool		is_from = stmt->is_from;
 	bool		pipe = (stmt->filename == NULL);
 	Relation	rel;
-	Oid			relid;
 	Node	   *query = NULL;
 	List	   *range_table = NIL;
 
@@ -194,8 +193,6 @@ PathmanDoCopy(const CopyStmt *stmt, const char *queryString, uint64 *processed)
 		/* Open the relation (we've locked it in is_pathman_related_copy()) */
 		rel = heap_openrv(stmt->relation, NoLock);
 
-		relid = RelationGetRelid(rel);
-
 		rte = makeNode(RangeTblEntry);
 		rte->rtekind = RTE_RELATION;
 		rte->relid = RelationGetRelid(rel);
@@ -280,7 +277,6 @@ PathmanDoCopy(const CopyStmt *stmt, const char *queryString, uint64 *processed)
 		Assert(stmt->query);
 
 		query = stmt->query;
-		relid = InvalidOid;
 		rel = NULL;
 	}
 
@@ -291,7 +287,7 @@ PathmanDoCopy(const CopyStmt *stmt, const char *queryString, uint64 *processed)
 		Assert(rel);
 
 		/* check read-only transaction and parallel mode */
-		if (XactReadOnly && !rel->rd_islocaltemp)
+		if (XactReadOnly && rel && !rel->rd_islocaltemp)
 			PreventCommandIfReadOnly("PATHMAN COPY FROM");
 		PreventCommandIfParallelMode("PATHMAN COPY FROM");
 
