Fix oversight in data-type change for autovacuum_vacuum_cost_delay.

tglsfdc · tglsfdc · commit 7c366ac969ce · 2019-03-26T13:32:38.000-04:00
Commit caf626b missed that the relevant reloptions entry needs to be moved from the intRelOpts[] array to realRelOpts[]. Somewhat surprisingly, it seems to work anyway, perhaps because the desired default and limit values are all integers. We ought to have either a simpler data structure or better cross-checking here, but that's for another patch. Nikolay Shaplov Discussion: https://postgr.es/m/4861742.12LTaSB3sv@x200m
diff --git a/src/backend/access/common/reloptions.c b/src/backend/access/common/reloptions.c
@@ -212,15 +212,6 @@ static relopt_int intRelOpts[] =
 		},
 		-1, 0, INT_MAX
 	},
-	{
-		{
-			"autovacuum_vacuum_cost_delay",
-			"Vacuum cost delay in milliseconds, for autovacuum",
-			RELOPT_KIND_HEAP | RELOPT_KIND_TOAST,
-			ShareUpdateExclusiveLock
-		},
-		-1, 0, 100
-	},
 	{
 		{
 			"autovacuum_vacuum_cost_limit",
@@ -346,6 +337,15 @@ static relopt_int intRelOpts[] =
 
 static relopt_real realRelOpts[] =
 {
+	{
+		{
+			"autovacuum_vacuum_cost_delay",
+			"Vacuum cost delay in milliseconds, for autovacuum",
+			RELOPT_KIND_HEAP | RELOPT_KIND_TOAST,
+			ShareUpdateExclusiveLock
+		},
+		-1, 0.0, 100.0
+	},
 	{
 		{
 			"autovacuum_vacuum_scale_factor",
