Fix logical replication to fire BEFORE ROW DELETE triggers.

robertmhaas · robertmhaas · commit 7cde649ab150 · 2017-10-12T10:26:54.000-04:00
Before, that would fail to happen unless a BEFORE ROW UPDATE trigger was also present. Noted by me while reviewing a patch from Masahiko Sawada, who also wrote this patch. Reviewed by Petr Jelinek. Discussion: http://postgr.es/m/CA+TgmobAZvCxduG8y_mQKBK7nz-vhbdLvjM354KEFozpuzMN5A@mail.gmail.com
diff --git a/src/backend/executor/execReplication.c b/src/backend/executor/execReplication.c
@@ -511,7 +511,7 @@ ExecSimpleRelationDelete(EState *estate, EPQState *epqstate,
 
 	/* BEFORE ROW DELETE Triggers */
 	if (resultRelInfo->ri_TrigDesc &&
-		resultRelInfo->ri_TrigDesc->trig_update_before_row)
+		resultRelInfo->ri_TrigDesc->trig_delete_before_row)
 	{
 		skip_tuple = !ExecBRDeleteTriggers(estate, epqstate, resultRelInfo,
 										   &searchslot->tts_tuple->t_self,

Original file line number	Diff line number	Diff line change
`@@ -511,7 +511,7 @@ ExecSimpleRelationDelete(EState estate, EPQState epqstate,`
`511`	`511`
`512`	`512`	`/* BEFORE ROW DELETE Triggers */`
`513`	`513`	`if (resultRelInfo->ri_TrigDesc &&`
`514`		`- resultRelInfo->ri_TrigDesc->trig_update_before_row)`
	`514`	`+ resultRelInfo->ri_TrigDesc->trig_delete_before_row)`
`515`	`515`	`{`
`516`	`516`	`skip_tuple = !ExecBRDeleteTriggers(estate, epqstate, resultRelInfo,`
`517`	`517`	`&searchslot->tts_tuple->t_self,`