fix execution window, get_log SELECT + OUTER JOIN && bgworker_restart time

Vladimir Ershov · Vladimir Ershov · commit 7e974b545a22 · 2017-03-02T17:13:29.000+03:00
diff --git a/pgpro_scheduler--2.0.sql b/pgpro_scheduler--2.0.sql
@@ -284,7 +284,12 @@ DECLARE
   cron_id INTEGER;
 BEGIN
   cron_id := NEW.id; 
-  IF NOT NEW.active OR NEW.broken OR NEW.rule <> OLD.rule OR NEW.postpone <> OLD.postpone  THEN
+  IF NOT NEW.active OR NEW.broken OR
+  	coalesce(NEW.rule <> OLD.rule, true) OR
+	coalesce(NEW.postpone <> OLD.postpone, true)  OR
+	coalesce(NEW.start_date <> OLD.start_date, true) OR
+	coalesce(NEW.end_date <> OLD.end_date, true)
+  THEN
      DELETE FROM at WHERE cron = cron_id AND active = false;
   END IF;
   RETURN OLD;
@@ -1206,9 +1211,9 @@ BEGIN
 	END IF;
 
 	IF usename = '___all___' THEN
-		sql_cmd := 'SELECT * FROM log as l , cron as cron WHERE cron.id = l.cron';
+		sql_cmd := 'SELECT * FROM log as l LEFT OUTER JOIN cron ON cron.id = l.cron';
 	ELSE
-		sql_cmd := 'SELECT * FROM log as l , cron as cron WHERE cron.executor = ''' || usename || ''' AND cron.id = l.cron';
+		sql_cmd := 'SELECT * FROM log as l LEFT OUTER JOIN cron ON cron.executor = ''' || usename || ''' AND cron.id = l.cron';
 	END IF;
 
 	FOR ii IN EXECUTE sql_cmd LOOP
diff --git a/src/pgpro_scheduler.c b/src/pgpro_scheduler.c
@@ -408,7 +408,7 @@ pg_scheduler_startup(void)
 	worker.bgw_flags = BGWORKER_SHMEM_ACCESS |
 		BGWORKER_BACKEND_DATABASE_CONNECTION;
 	worker.bgw_start_time = BgWorkerStart_ConsistentState;
-	worker.bgw_restart_time = BGW_NEVER_RESTART;
+	worker.bgw_restart_time = 10;
 	worker.bgw_main = NULL;
 	worker.bgw_notify_pid = 0;
 	worker.bgw_main_arg = Int32GetDatum(0);
diff --git a/src/scheduler_manager.c b/src/scheduler_manager.c
@@ -378,7 +378,7 @@ scheduler_task_t *scheduler_get_active_tasks(scheduler_manager_ctx_t *ctx, int *
 
 	*nt = 0;
 	initStringInfo(&sql);
-	appendStringInfo(&sql, "select id, rule, postpone, _next_exec_time, next_time_statement from cron where active and not broken and (start_date <= 'now' or start_date is null) and (end_date <= 'now' or end_date is null) and node = '%s'", ctx->nodename);
+	appendStringInfo(&sql, "select id, rule, postpone, _next_exec_time, next_time_statement from cron where active and not broken and (start_date <= 'now' or start_date is null) and (end_date >= 'now' or end_date is null) and node = '%s'", ctx->nodename);
 
 	pgstat_report_activity(STATE_RUNNING, "select 'at' tasks");
 
