Fix unportable isdigit() call --- must cast arg to unsigned char.

tglsfdc · tglsfdc · commit 83fea34b5b1f · 2004-11-20T02:09:47.000Z
diff --git a/src/backend/utils/adt/formatting.c b/src/backend/utils/adt/formatting.c
@@ -1,7 +1,7 @@
 /* -----------------------------------------------------------------------
  * formatting.c
  *
- * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.81 2004/11/01 14:33:10 momjian Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.82 2004/11/20 02:09:47 tgl Exp $
  *
  *
  *	 Portions Copyright (c) 1999-2004, PostgreSQL Global Development Group
@@ -3786,14 +3786,14 @@ NUM_numpart_from_char(NUMProc *Np, int id, int plen)
 	if (*Np->number == ' ' && Np->read_pre + Np->read_post > 0)
 	{
 		/*
-	   	 * locale sign (NUM_S) is always anchored behind a last number, if:
+		 * locale sign (NUM_S) is always anchored behind a last number, if:
 		 *	- locale sign expected
 		 *	- last read char was NUM_0/9 or NUM_DEC
 		 *	- and next char is not digit
-      		 */		 
+		 */		 
 		if (IS_LSIGN(Np->Num) && isread && 
-				(Np->inout_p+1) <= Np->inout + plen &&
-				isdigit(*(Np->inout_p+1))==0)
+			(Np->inout_p+1) <= Np->inout + plen &&
+			!isdigit((unsigned char) *(Np->inout_p+1)))
 		{
 			int x;
 			char *tmp = Np->inout_p++;

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/* -----------------------------------------------------------------------`
`2`	`2`	`* formatting.c`
`3`	`3`	`*`
`4`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.81 2004/11/01 14:33:10 momjian Exp $`
	`4`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.82 2004/11/20 02:09:47 tgl Exp $`
`5`	`5`	`*`
`6`	`6`	`*`
`7`	`7`	`* Portions Copyright (c) 1999-2004, PostgreSQL Global Development Group`
`@@ -3786,14 +3786,14 @@ NUM_numpart_from_char(NUMProc *Np, int id, int plen)`
`3786`	`3786`	`if (*Np->number == ' ' && Np->read_pre + Np->read_post > 0)`
`3787`	`3787`	`{`
`3788`	`3788`	`/*`
`3789`		`- * locale sign (NUM_S) is always anchored behind a last number, if:`
	`3789`	`+ * locale sign (NUM_S) is always anchored behind a last number, if:`
`3790`	`3790`	`* - locale sign expected`
`3791`	`3791`	`* - last read char was NUM_0/9 or NUM_DEC`
`3792`	`3792`	`* - and next char is not digit`
`3793`		`- */`
	`3793`	`+ */`
`3794`	`3794`	`if (IS_LSIGN(Np->Num) && isread &&`
`3795`		`- (Np->inout_p+1) <= Np->inout + plen &&`
`3796`		`- isdigit(*(Np->inout_p+1))==0)`
	`3795`	`+ (Np->inout_p+1) <= Np->inout + plen &&`
	`3796`	`+ !isdigit((unsigned char) *(Np->inout_p+1)))`
`3797`	`3797`	`{`
`3798`	`3798`	`int x;`
`3799`	`3799`	`char *tmp = Np->inout_p++;`