Disallow SETOF in the input of parseTypeString(). Formerly it was

tglsfdc · tglsfdc · commit 84dbd5a8f60c · 2004-12-15T20:15:17.000Z
silently ignored, allowing one to write bizarre things like
	DECLARE x setof int;
in plpgsql.  This has misled at least one novice into thinking that
plpgsql variables could be sets ...
diff --git a/src/backend/parser/parse_type.c b/src/backend/parser/parse_type.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/parser/parse_type.c,v 1.71 2004/08/29 05:06:44 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/parser/parse_type.c,v 1.72 2004/12/15 20:15:17 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -453,6 +453,8 @@ parseTypeString(const char *str, Oid *type_id, int32 *typmod)
 	if (typename == NULL ||
 		!IsA(typename, TypeName))
 		goto fail;
+	if (typename->setof)
+		goto fail;
 
 	*type_id = typenameTypeId(typename);
 	*typmod = typename->typmod;

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/parser/parse_type.c,v 1.71 2004/08/29 05:06:44 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/parser/parse_type.c,v 1.72 2004/12/15 20:15:17 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -453,6 +453,8 @@ parseTypeString(const char str, Oid type_id, int32 *typmod)`
`453`	`453`	`if (typename == NULL \|\|`
`454`	`454`	`!IsA(typename, TypeName))`
`455`	`455`	`goto fail;`
	`456`	`+ if (typename->setof)`
	`457`	`+ goto fail;`
`456`	`458`
`457`	`459`	`*type_id = typenameTypeId(typename);`
`458`	`460`	`*typmod = typename->typmod;`