Fix planning bug introduced in recent code reorganization for hashed

tglsfdc · tglsfdc · commit 89caf56b8639 · 2002-11-14T19:00:36.000Z
aggregates: tuple_fraction has to be adjusted before passing it to
compare_fractional_path_costs().
diff --git a/src/backend/optimizer/plan/planner.c b/src/backend/optimizer/plan/planner.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/optimizer/plan/planner.c,v 1.127 2002/11/06 22:31:24 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/optimizer/plan/planner.c,v 1.128 2002/11/14 19:00:36 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1257,6 +1257,9 @@ grouping_planner(Query *parse, double tuple_fraction)
 					  sorted_path->parent->rows, sorted_path->parent->width);
 			sort_path.startup_cost += cheapest_path->total_cost;
 			sort_path.total_cost += cheapest_path->total_cost;
+			/* Convert absolute-count tuple_fraction into a fraction */
+			if (tuple_fraction >= 1.0)
+				tuple_fraction /= sorted_path->parent->rows;
 			if (compare_fractional_path_costs(sorted_path, &sort_path,
 											  tuple_fraction) <= 0)
 			{

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/optimizer/plan/planner.c,v 1.127 2002/11/06 22:31:24 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/optimizer/plan/planner.c,v 1.128 2002/11/14 19:00:36 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -1257,6 +1257,9 @@ grouping_planner(Query *parse, double tuple_fraction)`
`1257`	`1257`	`sorted_path->parent->rows, sorted_path->parent->width);`
`1258`	`1258`	`sort_path.startup_cost += cheapest_path->total_cost;`
`1259`	`1259`	`sort_path.total_cost += cheapest_path->total_cost;`
	`1260`	`+ /* Convert absolute-count tuple_fraction into a fraction */`
	`1261`	`+ if (tuple_fraction >= 1.0)`
	`1262`	`+ tuple_fraction /= sorted_path->parent->rows;`
`1260`	`1263`	`if (compare_fractional_path_costs(sorted_path, &sort_path,`
`1261`	`1264`	`tuple_fraction) <= 0)`
`1262`	`1265`	`{`