Lock on the rule relation wasn't removed after adding the comment.

bmomjian · bmomjian · commit 8a7cfa3756ba · 2002-10-09T16:26:46.000Z
Added Tom's patch fix for heap_close.

Rod Taylor
diff --git a/src/backend/commands/comment.c b/src/backend/commands/comment.c
@@ -7,7 +7,7 @@
  * Copyright (c) 1996-2001, PostgreSQL Global Development Group
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/commands/comment.c,v 1.60 2002/09/04 20:31:14 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/commands/comment.c,v 1.61 2002/10/09 16:26:46 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -559,7 +559,6 @@ CommentRule(List *qualname, char *comment)
 	}
 
 	/* Check object security */
-
 	aclcheck = pg_class_aclcheck(reloid, GetUserId(), ACL_RULE);
 	if (aclcheck != ACLCHECK_OK)
 		aclcheck_error(aclcheck, rulename);
@@ -568,8 +567,9 @@ CommentRule(List *qualname, char *comment)
 	classoid = get_system_catalog_relid(RewriteRelationName);
 
 	/* Call CreateComments() to create/drop the comments */
-
 	CreateComments(ruleoid, classoid, 0, comment);
+
+	heap_close(relation, NoLock);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Copyright (c) 1996-2001, PostgreSQL Global Development Group`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/commands/comment.c,v 1.60 2002/09/04 20:31:14 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/comment.c,v 1.61 2002/10/09 16:26:46 momjian Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -559,7 +559,6 @@ CommentRule(List qualname, char comment)`
`559`	`559`	`}`
`560`	`560`
`561`	`561`	`/* Check object security */`
`562`		`-`
`563`	`562`	`aclcheck = pg_class_aclcheck(reloid, GetUserId(), ACL_RULE);`
`564`	`563`	`if (aclcheck != ACLCHECK_OK)`
`565`	`564`	`aclcheck_error(aclcheck, rulename);`
`@@ -568,8 +567,9 @@ CommentRule(List qualname, char comment)`
`568`	`567`	`classoid = get_system_catalog_relid(RewriteRelationName);`
`569`	`568`
`570`	`569`	`/* Call CreateComments() to create/drop the comments */`
`571`		`-`
`572`	`570`	`CreateComments(ruleoid, classoid, 0, comment);`
	`571`	`+`
	`572`	`+ heap_close(relation, NoLock);`
`573`	`573`	`}`
`574`	`574`
`575`	`575`	`/*`