Original coding of pg_regress.c made the results and log directories

tglsfdc · tglsfdc · commit 8aab1978406b · 2006-07-27T15:37:19.000Z
with restrictive permissions, which was not the behavior of the shell
script and doesn't seem very desirable.  Use the umask setting instead.
diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c
@@ -11,7 +11,7 @@
  * Portions Copyright (c) 1996-2006, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $PostgreSQL: pgsql/src/test/regress/pg_regress.c,v 1.15 2006/07/25 03:51:22 tgl Exp $
+ * $PostgreSQL: pgsql/src/test/regress/pg_regress.c,v 1.16 2006/07/27 15:37:19 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -790,7 +790,7 @@ directory_exists(const char *dir)
 static void
 make_directory(const char *dir)
 {
-	if (mkdir(dir, S_IRWXU) < 0)
+	if (mkdir(dir, S_IRWXU | S_IRWXG | S_IRWXO) < 0)
 	{
 		fprintf(stderr, _("%s: could not create directory \"%s\": %s\n"),
 				progname, dir, strerror(errno));

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`* Portions Copyright (c) 1996-2006, PostgreSQL Global Development Group`
`12`	`12`	`* Portions Copyright (c) 1994, Regents of the University of California`
`13`	`13`	`*`
`14`		`- * $PostgreSQL: pgsql/src/test/regress/pg_regress.c,v 1.15 2006/07/25 03:51:22 tgl Exp $`
	`14`	`+ * $PostgreSQL: pgsql/src/test/regress/pg_regress.c,v 1.16 2006/07/27 15:37:19 tgl Exp $`
`15`	`15`	`*`
`16`	`16`	`*-------------------------------------------------------------------------`
`17`	`17`	`*/`
`@@ -790,7 +790,7 @@ directory_exists(const char *dir)`
`790`	`790`	`static void`
`791`	`791`	`make_directory(const char *dir)`
`792`	`792`	`{`
`793`		`- if (mkdir(dir, S_IRWXU) < 0)`
	`793`	`+ if (mkdir(dir, S_IRWXU \| S_IRWXG \| S_IRWXO) < 0)`
`794`	`794`	`{`
`795`	`795`	`fprintf(stderr, _("%s: could not create directory \"%s\": %s\n"),`
`796`	`796`	`progname, dir, strerror(errno));`