RecordTransactionAbort() shouldn't log XLOG_XACT_ABORT

Hiroshi Inoue · Hiroshi Inoue · commit 8bb4dab94d26 · 2000-12-07T10:03:46.000Z
if the transaction has already been committed ?
diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/access/transam/xact.c,v 1.87 2000/12/03 10:27:26 vadim Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/access/transam/xact.c,v 1.88 2000/12/07 10:03:46 inoue Exp $
  *
  * NOTES
  *		Transaction aborts can now occur two ways:
@@ -783,7 +783,7 @@ RecordTransactionAbort(void)
 {
 	TransactionId xid = GetCurrentTransactionId();
 
-	if (MyLastRecPtr.xrecoff != 0)
+	if (MyLastRecPtr.xrecoff != 0 && !TransactionIdDidCommit(xid))
 	{
 		xl_xact_abort	xlrec;
 		XLogRecPtr		recptr;

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/access/transam/xact.c,v 1.87 2000/12/03 10:27:26 vadim Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/access/transam/xact.c,v 1.88 2000/12/07 10:03:46 inoue Exp $`
`12`	`12`	`*`
`13`	`13`	`* NOTES`
`14`	`14`	`* Transaction aborts can now occur two ways:`
`@@ -783,7 +783,7 @@ RecordTransactionAbort(void)`
`783`	`783`	`{`
`784`	`784`	`TransactionId xid = GetCurrentTransactionId();`
`785`	`785`
`786`		`- if (MyLastRecPtr.xrecoff != 0)`
	`786`	`+ if (MyLastRecPtr.xrecoff != 0 && !TransactionIdDidCommit(xid))`
`787`	`787`	`{`
`788`	`788`	`xl_xact_abort xlrec;`
`789`	`789`	`XLogRecPtr recptr;`