Call getsockopt() on the correct socket.

hlinnaka · hlinnaka · commit 8e33fc1784cb · 2015-07-06T16:36:48.000+03:00
We're interested in the buffer size of the socket that's connected to the
client, not the one that's listening for new connections. It happened to
work, as default buffer size is the same on both, but it was clearly not
wrong.

Spotted by Tom Lane
diff --git a/src/backend/libpq/pqcomm.c b/src/backend/libpq/pqcomm.c
@@ -773,7 +773,7 @@ StreamConnection(pgsocket server_fd, Port *port)
 		 * https://msdn.microsoft.com/en-us/library/bb736549%28v=vs.85%29.aspx
 		 */
 		optlen = sizeof(oldopt);
-		if (getsockopt(server_fd, SOL_SOCKET, SO_SNDBUF, (char *) &oldopt,
+		if (getsockopt(port->sock, SOL_SOCKET, SO_SNDBUF, (char *) &oldopt,
 					   &optlen) < 0)
 		{
 			elog(LOG, "getsockopt(SO_SNDBUF) failed: %m");

Original file line number	Diff line number	Diff line change
`@@ -773,7 +773,7 @@ StreamConnection(pgsocket server_fd, Port *port)`
`773`	`773`	`* https://msdn.microsoft.com/en-us/library/bb736549%28v=vs.85%29.aspx`
`774`	`774`	`*/`
`775`	`775`	`optlen = sizeof(oldopt);`
`776`		`- if (getsockopt(server_fd, SOL_SOCKET, SO_SNDBUF, (char *) &oldopt,`
	`776`	`+ if (getsockopt(port->sock, SOL_SOCKET, SO_SNDBUF, (char *) &oldopt,`
`777`	`777`	`&optlen) < 0)`
`778`	`778`	`{`
`779`	`779`	`elog(LOG, "getsockopt(SO_SNDBUF) failed: %m");`