Fix thinko introduced by 82a5649 in slot.c

michaelpq · michaelpq · commit 9010156445c4 · 2019-04-17T10:01:22.000+09:00
When saving a replication slot, failing to close the temporary path used
to save the slot information is considered as a failure and reported as
such.  However the code forgot to leave immediately as other failure
paths do.

Noticed while looking up at this area of the code for another patch.
diff --git a/src/backend/replication/slot.c b/src/backend/replication/slot.c
@@ -1316,10 +1316,13 @@ SaveSlotToPath(ReplicationSlot *slot, const char *dir, int elevel)
 	pgstat_report_wait_end();
 
 	if (CloseTransientFile(fd))
+	{
 		ereport(elevel,
 				(errcode_for_file_access(),
 				 errmsg("could not close file \"%s\": %m",
 						tmppath)));
+		return;
+	}
 
 	/* rename to permanent file, fsync file and directory */
 	if (rename(tmppath, path) != 0)
