Don't do logical replication of TRUNCATE of zero tables

petere · petere · commit 92e1583b439f · 2018-04-30T13:49:20.000-04:00
When due to publication configuration, a TRUNCATE change ends up with
zero tables to be published, don't send the message out, just skip it.
It's not wrong, but obviously useless overhead.
diff --git a/src/backend/replication/pgoutput/pgoutput.c b/src/backend/replication/pgoutput/pgoutput.c
@@ -407,13 +407,16 @@ pgoutput_truncate(LogicalDecodingContext *ctx, ReorderBufferTXN *txn,
 		maybe_send_schema(ctx, relation, relentry);
 	}
 
-	OutputPluginPrepareWrite(ctx, true);
-	logicalrep_write_truncate(ctx->out,
-							  nrelids,
-							  relids,
-							  change->data.truncate.cascade,
-							  change->data.truncate.restart_seqs);
-	OutputPluginWrite(ctx, true);
+	if (nrelids > 0)
+	{
+		OutputPluginPrepareWrite(ctx, true);
+		logicalrep_write_truncate(ctx->out,
+								  nrelids,
+								  relids,
+								  change->data.truncate.cascade,
+								  change->data.truncate.restart_seqs);
+		OutputPluginWrite(ctx, true);
+	}
 
 	MemoryContextSwitchTo(old);
 	MemoryContextReset(data->context);
