Additional thoughts on WALSender cpu reduction. Use long type

simonat2ndQuadrant · simonat2ndQuadrant · commit 92fc0db99fb7 · 2010-03-24T21:41:57.000Z
and alter a comment to reduce confusion.
diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c
@@ -30,7 +30,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/replication/walsender.c,v 1.11 2010/03/24 20:11:12 sriggs Exp $
+ *	  $PostgreSQL: pgsql/src/backend/replication/walsender.c,v 1.12 2010/03/24 21:41:57 sriggs Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -353,7 +353,7 @@ WalSndLoop(void)
 	/* Loop forever */
 	for (;;)
 	{
-		int			remain;		/* remaining time (ms) */
+		long	remain;		/* remaining time (us) */
 
 		/*
 		 * Emergency bailout if postmaster has died.  This is to avoid the
@@ -393,7 +393,7 @@ WalSndLoop(void)
 		 *
 		 * On some platforms, signals won't interrupt the sleep.  To ensure we
 		 * respond reasonably promptly when someone signals us, break down the
-		 * sleep into NAPTIME_PER_CYCLE (ms) increments, and check for
+		 * sleep into NAPTIME_PER_CYCLE increments, and check for
 		 * interrupts after each nap.
 		 */
 		remain = WalSndDelay * 1000L;

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@`
`30`	`30`	`*`
`31`	`31`	`*`
`32`	`32`	`* IDENTIFICATION`
`33`		`- * $PostgreSQL: pgsql/src/backend/replication/walsender.c,v 1.11 2010/03/24 20:11:12 sriggs Exp $`
	`33`	`+ * $PostgreSQL: pgsql/src/backend/replication/walsender.c,v 1.12 2010/03/24 21:41:57 sriggs Exp $`
`34`	`34`	`*`
`35`	`35`	`*-------------------------------------------------------------------------`
`36`	`36`	`*/`
`@@ -353,7 +353,7 @@ WalSndLoop(void)`
`353`	`353`	`/* Loop forever */`
`354`	`354`	`for (;;)`
`355`	`355`	`{`
`356`		`- int remain; /* remaining time (ms) */`
	`356`	`+ long remain; /* remaining time (us) */`
`357`	`357`
`358`	`358`	`/*`
`359`	`359`	`* Emergency bailout if postmaster has died. This is to avoid the`
`@@ -393,7 +393,7 @@ WalSndLoop(void)`
`393`	`393`	`*`
`394`	`394`	`* On some platforms, signals won't interrupt the sleep. To ensure we`
`395`	`395`	`* respond reasonably promptly when someone signals us, break down the`
`396`		`- * sleep into NAPTIME_PER_CYCLE (ms) increments, and check for`
	`396`	`+ * sleep into NAPTIME_PER_CYCLE increments, and check for`
`397`	`397`	`* interrupts after each nap.`
`398`	`398`	`*/`
`399`	`399`	`remain = WalSndDelay * 1000L;`