Suppress possibly-uninitialized-variable warnings.

tglsfdc · tglsfdc · commit 96102a32a374 · 2018-01-19T22:16:25.000-05:00
Apparently, Peter's compiler has faith that the switch test values here
could never not be valid values of their enums.  Mine does not, and
I tend to agree with it.
diff --git a/src/backend/catalog/aclchk.c b/src/backend/catalog/aclchk.c
@@ -3359,7 +3359,7 @@ aclcheck_error(AclResult aclerr, ObjectType objtype,
 			break;
 		case ACLCHECK_NO_PRIV:
 			{
-				const char *msg;
+				const char *msg = "???";
 
 				switch (objtype)
 				{
@@ -3481,7 +3481,6 @@ aclcheck_error(AclResult aclerr, ObjectType objtype,
 					case OBJECT_TSTEMPLATE:
 					case OBJECT_USER_MAPPING:
 						elog(ERROR, "unsupported object type %d", objtype);
-						msg = "???";
 				}
 
 				ereport(ERROR,
@@ -3491,7 +3490,7 @@ aclcheck_error(AclResult aclerr, ObjectType objtype,
 			}
 		case ACLCHECK_NOT_OWNER:
 			{
-				const char *msg;
+				const char *msg = "???";
 
 				switch (objtype)
 				{
@@ -3616,7 +3615,6 @@ aclcheck_error(AclResult aclerr, ObjectType objtype,
 					case OBJECT_TSTEMPLATE:
 					case OBJECT_USER_MAPPING:
 						elog(ERROR, "unsupported object type %d", objtype);
-						msg = "???";
 				}
 
 				ereport(ERROR,

Original file line number	Diff line number	Diff line change
`@@ -3359,7 +3359,7 @@ aclcheck_error(AclResult aclerr, ObjectType objtype,`
`3359`	`3359`	`break;`
`3360`	`3360`	`case ACLCHECK_NO_PRIV:`
`3361`	`3361`	`{`
`3362`		`- const char *msg;`
	`3362`	`+ const char *msg = "???";`
`3363`	`3363`
`3364`	`3364`	`switch (objtype)`
`3365`	`3365`	`{`
`@@ -3481,7 +3481,6 @@ aclcheck_error(AclResult aclerr, ObjectType objtype,`
`3481`	`3481`	`case OBJECT_TSTEMPLATE:`
`3482`	`3482`	`case OBJECT_USER_MAPPING:`
`3483`	`3483`	`elog(ERROR, "unsupported object type %d", objtype);`
`3484`		`- msg = "???";`
`3485`	`3484`	`}`
`3486`	`3485`
`3487`	`3486`	`ereport(ERROR,`
`@@ -3491,7 +3490,7 @@ aclcheck_error(AclResult aclerr, ObjectType objtype,`
`3491`	`3490`	`}`
`3492`	`3491`	`case ACLCHECK_NOT_OWNER:`
`3493`	`3492`	`{`
`3494`		`- const char *msg;`
	`3493`	`+ const char *msg = "???";`
`3495`	`3494`
`3496`	`3495`	`switch (objtype)`
`3497`	`3496`	`{`
`@@ -3616,7 +3615,6 @@ aclcheck_error(AclResult aclerr, ObjectType objtype,`
`3616`	`3615`	`case OBJECT_TSTEMPLATE:`
`3617`	`3616`	`case OBJECT_USER_MAPPING:`
`3618`	`3617`	`elog(ERROR, "unsupported object type %d", objtype);`
`3619`		`- msg = "???";`
`3620`	`3618`	`}`
`3621`	`3619`
`3622`	`3620`	`ereport(ERROR,`