Don't call PG_RETURN_BOOL() in a function not returning Datum.

nmisch · nmisch · commit 9a81c9fa3f6a · 2019-06-23T12:02:19.000-07:00
This code is new in v12, and the defect probably was not user-visible.
diff --git a/src/backend/utils/adt/timestamp.c b/src/backend/utils/adt/timestamp.c
@@ -5180,8 +5180,8 @@ TimestampTimestampTzRequiresRewrite(void)
 	long		offset;
 
 	if (pg_get_timezone_offset(session_timezone, &offset) && offset == 0)
-		PG_RETURN_BOOL(false);
-	PG_RETURN_BOOL(true);
+		return false;
+	return true;
 }
 
 /* timestamp_timestamptz()

Original file line number	Diff line number	Diff line change
`@@ -5180,8 +5180,8 @@ TimestampTimestampTzRequiresRewrite(void)`
`5180`	`5180`	`long offset;`
`5181`	`5181`
`5182`	`5182`	`if (pg_get_timezone_offset(session_timezone, &offset) && offset == 0)`
`5183`		`- PG_RETURN_BOOL(false);`
`5184`		`- PG_RETURN_BOOL(true);`
	`5183`	`+ return false;`
	`5184`	`+ return true;`
`5185`	`5185`	`}`
`5186`	`5186`
`5187`	`5187`	`/* timestamp_timestamptz()`