Make TupleDescInitBuiltinEntry throw error for unsupported types.

tglsfdc · tglsfdc · commit a628e0c5b484 · 2018-12-10T10:38:49.000-05:00
Previously, it would just pass back a partially-uninitialized tupdesc, which doesn't seem like a safe or useful behavior. Backpatch to v10 where this code came in. Discussion: https://postgr.es/m/30830.1544384975@sss.pgh.pa.us
diff --git a/src/backend/access/common/tupdesc.c b/src/backend/access/common/tupdesc.c
@@ -748,6 +748,9 @@ TupleDescInitBuiltinEntry(TupleDesc desc,
 			att->attstorage = 'p';
 			att->attcollation = InvalidOid;
 			break;
+
+		default:
+			elog(ERROR, "unsupported type %u", oidtypeid);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -748,6 +748,9 @@ TupleDescInitBuiltinEntry(TupleDesc desc,`
`748`	`748`	`att->attstorage = 'p';`
`749`	`749`	`att->attcollation = InvalidOid;`
`750`	`750`	`break;`
	`751`	`+`
	`752`	`+ default:`
	`753`	`+ elog(ERROR, "unsupported type %u", oidtypeid);`
`751`	`754`	`}`
`752`	`755`	`}`
`753`	`756`