Skip to content

Commit aa0f6e8

Browse files
committed
Add comment marking non-exact time conversion macros.
1 parent 9dbd00b commit aa0f6e8

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

src/include/utils/timestamp.h

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* Portions Copyright (c) 1996-2005, PostgreSQL Global Development Group
77
* Portions Copyright (c) 1994, Regents of the University of California
88
*
9-
* $PostgreSQL: pgsql/src/include/utils/timestamp.h,v 1.48 2005/07/21 03:56:24 momjian Exp $
9+
* $PostgreSQL: pgsql/src/include/utils/timestamp.h,v 1.49 2005/07/21 04:48:42 momjian Exp $
1010
*
1111
*-------------------------------------------------------------------------
1212
*/
@@ -61,13 +61,12 @@ typedef struct
6161
#define MAX_INTERVAL_PRECISION 6
6262

6363
/* in both timestamp.h and ecpg/dt.h */
64-
#define DAYS_PER_YEAR 365.25
64+
#define DAYS_PER_YEAR 365.25 /* assumes leap year every four years */
6565
#define MONTHS_PER_YEAR 12
66-
/* average days per month */
67-
#define DAYS_PER_MONTH 30
68-
#define HOURS_PER_DAY 24
66+
#define DAYS_PER_MONTH 30 /* assumes exactly 30 days per month */
67+
#define HOURS_PER_DAY 24 /* assume no daylight savings time changes */
6968

70-
#define SECS_PER_DAY 86400
69+
#define SECS_PER_DAY 86400 /* assumes no leap second */
7170
#define SECS_PER_HOUR 3600
7271
#define SECS_PER_MINUTE 60
7372

src/interfaces/ecpg/pgtypeslib/dt.h

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -217,13 +217,12 @@ do { \
217217
#endif
218218

219219
/* in both timestamp.h and ecpg/dt.h */
220-
#define DAYS_PER_YEAR 365.25
220+
#define DAYS_PER_YEAR 365.25 /* assumes leap year every four years */
221221
#define MONTHS_PER_YEAR 12
222-
/* average days per month */
223-
#define DAYS_PER_MONTH 30
224-
#define HOURS_PER_DAY 24
222+
#define DAYS_PER_MONTH 30 /* assumes exactly 30 days per month */
223+
#define HOURS_PER_DAY 24 /* assume no daylight savings time changes */
225224

226-
#define SECS_PER_DAY 86400
225+
#define SECS_PER_DAY 86400 /* assumes no leap second */
227226
#define SECS_PER_HOUR 3600
228227
#define SECS_PER_MINUTE 60
229228

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy