Make factorial(0) return 1, as per spec.

bmomjian · bmomjian · commit ab786f6299b8 · 2002-02-23T01:01:30.000Z
diff --git a/src/backend/utils/adt/int.c b/src/backend/utils/adt/int.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/int.c,v 1.47 2001/06/07 00:09:29 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/int.c,v 1.48 2002/02/23 01:01:30 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -784,7 +784,9 @@ int4fac(PG_FUNCTION_ARGS)
 	int32		arg1 = PG_GETARG_INT32(0);
 	int32		result;
 
-	if (arg1 < 1)
+	if (arg1 == 0)
+		result = 1;
+	else if (arg1 < 1)
 		result = 0;
 	else
 		for (result = 1; arg1 > 0; --arg1)
diff --git a/src/backend/utils/adt/int8.c b/src/backend/utils/adt/int8.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/int8.c,v 1.36 2001/11/24 19:57:06 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/int8.c,v 1.37 2002/02/23 01:01:30 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -515,7 +515,9 @@ int8fac(PG_FUNCTION_ARGS)
 	int64		result;
 	int64		i;
 
-	if (arg1 < 1)
+	if (arg1 == 0)
+		result = 1;
+	else if (arg1 < 1)
 		result = 0;
 	else
 		for (i = arg1, result = 1; i > 0; --i)

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/int.c,v 1.47 2001/06/07 00:09:29 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/int.c,v 1.48 2002/02/23 01:01:30 momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -784,7 +784,9 @@ int4fac(PG_FUNCTION_ARGS)`
`784`	`784`	`int32 arg1 = PG_GETARG_INT32(0);`
`785`	`785`	`int32 result;`
`786`	`786`
`787`		`- if (arg1 < 1)`
	`787`	`+ if (arg1 == 0)`
	`788`	`+ result = 1;`
	`789`	`+ else if (arg1 < 1)`
`788`	`790`	`result = 0;`
`789`	`791`	`else`
`790`	`792`	`for (result = 1; arg1 > 0; --arg1)`