Remove unnecessary use of index_open just to get the index name.

tglsfdc · tglsfdc · commit abc6441d6069 · 2004-09-30T17:42:42.000Z
diff --git a/src/backend/commands/explain.c b/src/backend/commands/explain.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1994-5, Regents of the University of California
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/explain.c,v 1.126 2004/09/13 20:06:28 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/explain.c,v 1.127 2004/09/30 17:42:42 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -502,13 +502,12 @@ explain_outNode(StringInfo str,
 			i = 0;
 			foreach(l, ((IndexScan *) plan)->indxid)
 			{
-				Relation	relation;
+				char	   *indname;
 
-				relation = index_open(lfirst_oid(l));
+				indname = get_rel_name(lfirst_oid(l));
 				appendStringInfo(str, "%s%s",
 								 (++i > 1) ? ", " : "",
-					quote_identifier(RelationGetRelationName(relation)));
-				index_close(relation);
+								 quote_identifier(indname));
 			}
 			/* FALL THRU */
 		case T_SeqScan:

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1994-5, Regents of the University of California`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $PostgreSQL: pgsql/src/backend/commands/explain.c,v 1.126 2004/09/13 20:06:28 tgl Exp $`
	`10`	`+ * $PostgreSQL: pgsql/src/backend/commands/explain.c,v 1.127 2004/09/30 17:42:42 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -502,13 +502,12 @@ explain_outNode(StringInfo str,`
`502`	`502`	`i = 0;`
`503`	`503`	`foreach(l, ((IndexScan *) plan)->indxid)`
`504`	`504`	`{`
`505`		`- Relation relation;`
	`505`	`+ char *indname;`
`506`	`506`
`507`		`- relation = index_open(lfirst_oid(l));`
	`507`	`+ indname = get_rel_name(lfirst_oid(l));`
`508`	`508`	`appendStringInfo(str, "%s%s",`
`509`	`509`	`(++i > 1) ? ", " : "",`
`510`		`- quote_identifier(RelationGetRelationName(relation)));`
`511`		`- index_close(relation);`
	`510`	`+ quote_identifier(indname));`
`512`	`511`	`}`
`513`	`512`	`/* FALL THRU */`
`514`	`513`	`case T_SeqScan:`