Restpore assert in arbiter on receiving PREPARE in aborted state

knizhnik · kelvich · commit acf18301988e · 2017-11-13T00:17:10.000+03:00
diff --git a/arbiter.c b/arbiter.c
@@ -915,15 +915,17 @@ static void MtmTransReceiver(Datum arg)
 					} else { 
 						switch (msg->code) { 
 						  case MSG_PREPARE:
-							if (ts->status == TRANSACTION_STATUS_IN_PROGRESS) { 
-								ts->status = TRANSACTION_STATUS_UNKNOWN;
-								ts->csn = MtmAssignCSN();
-								MtmAdjustSubtransactions(ts);
-								MtmSendNotificationMessage(ts, MSG_PREPARED);
+							Assert(ts->status == TRANSACTION_STATUS_IN_PROGRESS);
+							ts->status = TRANSACTION_STATUS_UNKNOWN;
+							ts->csn = MtmAssignCSN();
+							MtmAdjustSubtransactions(ts);
+							MtmSendNotificationMessage(ts, MSG_PREPARED);
+#if 0							
 							} else {
 								Assert(ts->status == TRANSACTION_STATUS_ABORTED);
 								MtmSendNotificationMessage(ts, MSG_ABORTED);
 							}
+#endif
 							break;
 						  default:
 							Assert(false);
diff --git a/multimaster.c b/multimaster.c
@@ -797,7 +797,7 @@ void MtmWatchdog(void)
 			if (Mtm->nodes[i].lastHeartbeat != 0
 				&& now > Mtm->nodes[i].lastHeartbeat + MSEC_TO_USEC(MtmHeartbeatRecvTimeout)) 
 			{ 
-				elog(WARNING, "Heartbeat was received from node %d during %d msec", 
+				elog(WARNING, "Heartbeat is not received from node %d during %d msec", 
 					 i+1, (int)USEC_TO_MSEC(now - Mtm->nodes[i].lastHeartbeat));
 				MtmOnNodeDisconnect(i+1);				
 			}

Original file line number	Diff line number	Diff line change
`@@ -797,7 +797,7 @@ void MtmWatchdog(void)`
`797`	`797`	`if (Mtm->nodes[i].lastHeartbeat != 0`
`798`	`798`	`&& now > Mtm->nodes[i].lastHeartbeat + MSEC_TO_USEC(MtmHeartbeatRecvTimeout))`
`799`	`799`	`{`
`800`		`- elog(WARNING, "Heartbeat was received from node %d during %d msec",`
	`800`	`+ elog(WARNING, "Heartbeat is not received from node %d during %d msec",`
`801`	`801`	`i+1, (int)USEC_TO_MSEC(now - Mtm->nodes[i].lastHeartbeat));`
`802`	`802`	`MtmOnNodeDisconnect(i+1);`
`803`	`803`	`}`