Skip to content

Commit af38498

Browse files
alvherrealvherre
committed
Move hash_any prototype from access/hash.h to utils/hashutils.h
... as well as its implementation from backend/access/hash/hashfunc.c to backend/utils/hash/hashfn.c. access/hash is the place for the hash index AM, not really appropriate for generic facilities, which is what hash_any is; having things the old way meant that anything using hash_any had to include the AM's include file, pointlessly polluting its namespace with unrelated, unnecessary cruft. Also move the HTEqual strategy number to access/stratnum.h from access/hash.h. To avoid breaking third-party extension code, add an #include "utils/hashutils.h" to access/hash.h. (An easily removed line by committers who enjoy their asbestos suits to protect them from angry extension authors.) Discussion: https://postgr.es/m/201901251935.ser5e4h6djt2@alvherre.pgsql
1 parent b212245 commit af38498

40 files changed

+690
-687
lines changed

‎contrib/citext/citext.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
*/
44
#include "postgres.h"
55

6-
#include "access/hash.h"
76
#include "catalog/pg_collation.h"
87
#include "utils/builtins.h"
98
#include "utils/formatting.h"
9+
#include "utils/hashutils.h"
1010
#include "utils/varlena.h"
1111

1212
PG_MODULE_MAGIC;

‎contrib/hstore/hstore_op.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
*/
44
#include "postgres.h"
55

6-
#include "access/hash.h"
76
#include "access/htup_details.h"
87
#include "catalog/pg_type.h"
98
#include "funcapi.h"
109
#include "utils/builtins.h"
10+
#include "utils/hashutils.h"
1111
#include "utils/memutils.h"
1212

1313
#include "hstore.h"

‎contrib/pg_stat_statements/pg_stat_statements.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@
6161
#include <sys/stat.h>
6262
#include <unistd.h>
6363

64-
#include "access/hash.h"
6564
#include "catalog/pg_authid.h"
6665
#include "executor/instrument.h"
6766
#include "funcapi.h"
@@ -78,6 +77,7 @@
7877
#include "tcop/utility.h"
7978
#include "utils/acl.h"
8079
#include "utils/builtins.h"
80+
#include "utils/hashutils.h"
8181
#include "utils/memutils.h"
8282

8383
PG_MODULE_MAGIC;

‎contrib/sepgsql/uavc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@
1212
*/
1313
#include "postgres.h"
1414

15-
#include "access/hash.h"
1615
#include "catalog/pg_proc.h"
1716
#include "commands/seclabel.h"
1817
#include "storage/ipc.h"
1918
#include "utils/guc.h"
19+
#include "utils/hashutils.h"
2020
#include "utils/memutils.h"
2121

2222
#include "sepgsql.h"

‎src/backend/access/common/tupdesc.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
#include "postgres.h"
2121

22-
#include "access/hash.h"
2322
#include "access/htup_details.h"
2423
#include "access/tupdesc_details.h"
2524
#include "catalog/pg_collation.h"

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy