Add missing newline to error messages

petere · petere · commit afcb0c97efc5 · 2017-02-06T09:47:39.000-05:00
Also improve the message style a bit while we're here.
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -11489,7 +11489,7 @@ dumpCast(Archive *fout, CastInfo *cast)
 	{
 		funcInfo = findFuncByOid(cast->castfunc);
 		if (funcInfo == NULL)
-			exit_horribly(NULL, "unable to find function definition for OID %u",
+			exit_horribly(NULL, "could not find function definition for function with OID %u\n",
 						  cast->castfunc);
 	}
 
@@ -11599,14 +11599,14 @@ dumpTransform(Archive *fout, TransformInfo *transform)
 	{
 		fromsqlFuncInfo = findFuncByOid(transform->trffromsql);
 		if (fromsqlFuncInfo == NULL)
-			exit_horribly(NULL, "unable to find function definition for OID %u",
+			exit_horribly(NULL, "could not find function definition for function with OID %u\n",
 						  transform->trffromsql);
 	}
 	if (OidIsValid(transform->trftosql))
 	{
 		tosqlFuncInfo = findFuncByOid(transform->trftosql);
 		if (tosqlFuncInfo == NULL)
-			exit_horribly(NULL, "unable to find function definition for OID %u",
+			exit_horribly(NULL, "could not find function definition for function with OID %u\n",
 						  transform->trftosql);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -11489,7 +11489,7 @@ dumpCast(Archive fout, CastInfo cast)`
`11489`	`11489`	`{`
`11490`	`11490`	`funcInfo = findFuncByOid(cast->castfunc);`
`11491`	`11491`	`if (funcInfo == NULL)`
`11492`		`- exit_horribly(NULL, "unable to find function definition for OID %u",`
	`11492`	`+ exit_horribly(NULL, "could not find function definition for function with OID %u\n",`
`11493`	`11493`	`cast->castfunc);`
`11494`	`11494`	`}`
`11495`	`11495`
`@@ -11599,14 +11599,14 @@ dumpTransform(Archive fout, TransformInfo transform)`
`11599`	`11599`	`{`
`11600`	`11600`	`fromsqlFuncInfo = findFuncByOid(transform->trffromsql);`
`11601`	`11601`	`if (fromsqlFuncInfo == NULL)`
`11602`		`- exit_horribly(NULL, "unable to find function definition for OID %u",`
	`11602`	`+ exit_horribly(NULL, "could not find function definition for function with OID %u\n",`
`11603`	`11603`	`transform->trffromsql);`
`11604`	`11604`	`}`
`11605`	`11605`	`if (OidIsValid(transform->trftosql))`
`11606`	`11606`	`{`
`11607`	`11607`	`tosqlFuncInfo = findFuncByOid(transform->trftosql);`
`11608`	`11608`	`if (tosqlFuncInfo == NULL)`
`11609`		`- exit_horribly(NULL, "unable to find function definition for OID %u",`
	`11609`	`+ exit_horribly(NULL, "could not find function definition for function with OID %u\n",`
`11610`	`11610`	`transform->trftosql);`
`11611`	`11611`	`}`
`11612`	`11612`