Correct obsolete amcheck comments.

petergeoghegan · petergeoghegan · commit b00326df7ad4 · 2019-06-24T10:31:58.000-07:00
Oversight in commit dd299df.
diff --git a/contrib/amcheck/verify_nbtree.c b/contrib/amcheck/verify_nbtree.c
@@ -798,23 +798,25 @@ bt_check_level_from_leftmost(BtreeCheckState *state, BtreeLevel level)
  * target page:
  *
  * - That every "real" data item is less than or equal to the high key, which
- *	 is an upper bound on the items on the pages (where there is a high key at
- *	 all -- pages that are rightmost lack one).
+ *	 is an upper bound on the items on the page.  Data items should be
+ *	 strictly less than the high key when the page is an internal page.
  *
- * - That within the page, every "real" item is less than or equal to the item
- *	 immediately to its right, if any (i.e., that the items are in order within
- *	 the page, so that the binary searches performed by index scans are sane).
+ * - That within the page, every data item is strictly less than the item
+ *	 immediately to its right, if any (i.e., that the items are in order
+ *	 within the page, so that the binary searches performed by index scans are
+ *	 sane).
  *
- * - That the last item stored on the page is less than or equal to the first
- *	 "real" data item on the page to the right (if such a first item is
+ * - That the last data item stored on the page is strictly less than the
+ *	 first data item on the page to the right (when such a first item is
  *	 available).
  *
- * - That tuples report that they have the expected number of attributes.
- *	 INCLUDE index pivot tuples should not contain non-key attributes.
+ * - Various checks on the structure of tuples themselves.  For example, check
+ *	 that non-pivot tuples have no truncated attributes.
  *
  * Furthermore, when state passed shows ShareLock held, function also checks:
  *
- * - That all child pages respect downlinks lower bound.
+ * - That all child pages respect strict lower bound from parent's pivot
+ *	 tuple.
  *
  * - That downlink to block was encountered in parent where that's expected.
  *   (Limited to heapallindexed readonly callers.)

Original file line number	Diff line number	Diff line change
`@@ -798,23 +798,25 @@ bt_check_level_from_leftmost(BtreeCheckState *state, BtreeLevel level)`
`798`	`798`	`* target page:`
`799`	`799`	`*`
`800`	`800`	`* - That every "real" data item is less than or equal to the high key, which`
`801`		`- * is an upper bound on the items on the pages (where there is a high key at`
`802`		`- * all -- pages that are rightmost lack one).`
	`801`	`+ * is an upper bound on the items on the page. Data items should be`
	`802`	`+ * strictly less than the high key when the page is an internal page.`
`803`	`803`	`*`
`804`		`- * - That within the page, every "real" item is less than or equal to the item`
`805`		`- * immediately to its right, if any (i.e., that the items are in order within`
`806`		`- * the page, so that the binary searches performed by index scans are sane).`
	`804`	`+ * - That within the page, every data item is strictly less than the item`
	`805`	`+ * immediately to its right, if any (i.e., that the items are in order`
	`806`	`+ * within the page, so that the binary searches performed by index scans are`
	`807`	`+ * sane).`
`807`	`808`	`*`
`808`		`- * - That the last item stored on the page is less than or equal to the first`
`809`		`- * "real" data item on the page to the right (if such a first item is`
	`809`	`+ * - That the last data item stored on the page is strictly less than the`
	`810`	`+ * first data item on the page to the right (when such a first item is`
`810`	`811`	`* available).`
`811`	`812`	`*`
`812`		`- * - That tuples report that they have the expected number of attributes.`
`813`		`- * INCLUDE index pivot tuples should not contain non-key attributes.`
	`813`	`+ * - Various checks on the structure of tuples themselves. For example, check`
	`814`	`+ * that non-pivot tuples have no truncated attributes.`
`814`	`815`	`*`
`815`	`816`	`* Furthermore, when state passed shows ShareLock held, function also checks:`
`816`	`817`	`*`
`817`		`- * - That all child pages respect downlinks lower bound.`
	`818`	`+ * - That all child pages respect strict lower bound from parent's pivot`
	`819`	`+ * tuple.`
`818`	`820`	`*`
`819`	`821`	`* - That downlink to block was encountered in parent where that's expected.`
`820`	`822`	`* (Limited to heapallindexed readonly callers.)`