Per discussion earlier today, here is a fix that lets ereport() on win32

bmomjian · bmomjian · commit b00d50d3657b · 2004-04-22T03:51:24.000Z
report socket errors.

Magnus Hagander
diff --git a/src/backend/port/win32/socket.c b/src/backend/port/win32/socket.c
@@ -6,7 +6,7 @@
  * Portions Copyright (c) 1996-2003, PostgreSQL Global Development Group
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/port/win32/socket.c,v 1.1 2004/04/12 16:19:18 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/port/win32/socket.c,v 1.2 2004/04/22 03:50:54 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -432,3 +432,35 @@ int pgwin32_select(int nfds, fd_set* readfds, fd_set* writefds, fd_set* exceptfd
 	return nummatches;
 }
 
+
+/* 
+ * Return win32 error string, since strerror can't
+ * handle winsock codes 
+ */
+static char wserrbuf[256];
+const char *
+pgwin32_socket_strerror(int err)
+{
+	static HANDLE handleDLL = INVALID_HANDLE_VALUE;
+
+	if (handleDLL == INVALID_HANDLE_VALUE) {
+		handleDLL = LoadLibraryEx("netmsg.dll", NULL, DONT_RESOLVE_DLL_REFERENCES | LOAD_LIBRARY_AS_DATAFILE);
+		if (handleDLL ==  NULL)
+			ereport(FATAL,
+					(errmsg_internal("Failed to load netmsg.dll: %i",(int)GetLastError())));
+	}
+
+	ZeroMemory(&wserrbuf, sizeof(wserrbuf));
+	if (FormatMessage(FORMAT_MESSAGE_IGNORE_INSERTS | FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_FROM_HMODULE,
+					  handleDLL,
+					  err,
+					  MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),
+					  wserrbuf,
+					  sizeof(wserrbuf)-1,
+					  NULL) == 0) {
+		/* Failed to get id */
+		sprintf(wserrbuf,"Unknown winsock error %i",err);
+	}
+	return wserrbuf;
+}
+
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
@@ -37,7 +37,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.134 2004/04/16 12:59:05 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.135 2004/04/22 03:51:09 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1661,6 +1661,11 @@ useful_strerror(int errnum)
 	static char errorstr_buf[48];
 	const char *str;
 
+#ifdef WIN32
+	/* Winsock error code range, per WinError.h */
+	if (errnum >= 10000 && errnum <= 11999)
+		return pgwin32_socket_strerror(errnum);
+#endif
 	str = strerror(errnum);
 
 	/*
diff --git a/src/include/port/win32.h b/src/include/port/win32.h
@@ -1,4 +1,4 @@
-/* $PostgreSQL: pgsql/src/include/port/win32.h,v 1.22 2004/04/19 17:42:59 momjian Exp $ */
+/* $PostgreSQL: pgsql/src/include/port/win32.h,v 1.23 2004/04/22 03:51:24 momjian Exp $ */
 
 /* undefine and redefine after #include */
 #undef mkdir
@@ -139,6 +139,8 @@ int pgwin32_connect(SOCKET s, const struct sockaddr* name, int namelen);
 int pgwin32_select(int nfds, fd_set* readfs, fd_set* writefds, fd_set* exceptfds, const struct timeval* timeout);
 int pgwin32_recv(SOCKET s, char* buf, int len, int flags);
 int pgwin32_send(SOCKET s, char* buf, int len, int flags);
+
+const char *pgwin32_socket_strerror(int err);
 #endif
 
 

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@`
`37`	`37`	`*`
`38`	`38`	`*`
`39`	`39`	`* IDENTIFICATION`
`40`		`- * $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.134 2004/04/16 12:59:05 momjian Exp $`
	`40`	`+ * $PostgreSQL: pgsql/src/backend/utils/error/elog.c,v 1.135 2004/04/22 03:51:09 momjian Exp $`
`41`	`41`	`*`
`42`	`42`	`*-------------------------------------------------------------------------`
`43`	`43`	`*/`
`@@ -1661,6 +1661,11 @@ useful_strerror(int errnum)`
`1661`	`1661`	`static char errorstr_buf[48];`
`1662`	`1662`	`const char *str;`
`1663`	`1663`
	`1664`	`+#ifdef WIN32`
	`1665`	`+ /* Winsock error code range, per WinError.h */`
	`1666`	`+ if (errnum >= 10000 && errnum <= 11999)`
	`1667`	`+ return pgwin32_socket_strerror(errnum);`
	`1668`	`+#endif`
`1664`	`1669`	`str = strerror(errnum);`
`1665`	`1670`
`1666`	`1671`	`/*`