Remove surplus call to table_finish_bulk_insert

david-rowley · david-rowley · commit b2d69806d8cc · 2019-07-02T03:07:15.000+12:00
4de6024 added the call to table_finish_bulk_insert to the CopyMultiInsertBufferCleanup function. We use a CopyMultiInsertBuffer even for non-partitioned tables, so having the cleanup do that meant we would call table_finsh_bulk_insert twice when performing COPY FROM with a non-partitioned table. Here we can just remove the direct call in CopyFrom and let CopyMultiInsertBufferCleanup handle the call instead.
diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c
@@ -3369,8 +3369,6 @@ CopyFrom(CopyState cstate)
 
 	if (insertMethod != CIM_SINGLE)
 	{
-		table_finish_bulk_insert(cstate->rel, ti_options);
-
 		/* Tear down the multi-insert buffer data */
 		CopyMultiInsertInfoCleanup(&multiInsertInfo);
 	}

Original file line number	Diff line number	Diff line change
`@@ -3369,8 +3369,6 @@ CopyFrom(CopyState cstate)`
`3369`	`3369`
`3370`	`3370`	`if (insertMethod != CIM_SINGLE)`
`3371`	`3371`	`{`
`3372`		`- table_finish_bulk_insert(cstate->rel, ti_options);`
`3373`		`-`
`3374`	`3372`	`/* Tear down the multi-insert buffer data */`
`3375`	`3373`	`CopyMultiInsertInfoCleanup(&multiInsertInfo);`
`3376`	`3374`	`}`