Fix thinko in copyParamList.

robertmhaas · robertmhaas · commit b31875b1fe71 · 2016-07-27T10:20:40.000-04:00
There's no point in consulting retval-&gt;paramMask; it's always NULL.
Instead, we should consult from-&gt;paramMask.

Reported by Andrew Gierth.
diff --git a/src/backend/nodes/params.c b/src/backend/nodes/params.c
@@ -61,8 +61,8 @@ copyParamList(ParamListInfo from)
 		bool		typByVal;
 
 		/* Ignore parameters we don't need, to save cycles and space. */
-		if (retval->paramMask != NULL &&
-			!bms_is_member(i, retval->paramMask))
+		if (from->paramMask != NULL &&
+			!bms_is_member(i, from->paramMask))
 		{
 			nprm->value = (Datum) 0;
 			nprm->isnull = true;
