Remove wrong CloseHandle() call.

nmisch · nmisch · commit b37da1e8a0e4 · 2016-12-03T15:46:35.000-05:00
In accordance with its own documentation, invoke CloseHandle() only when
directed in the documentation for the function that furnished the
handle.  GetModuleHandle() does not so direct.  We have been issuing
this call only in the rare event that a CRT DLL contains no "_putenv"
symbol, so lack of bug reports is uninformative.  Back-patch to 9.2 (all
supported versions).

Christian Ullrich, reviewed by Michael Paquier.
diff --git a/src/port/win32env.c b/src/port/win32env.c
@@ -92,7 +92,6 @@ pgwin32_putenv(const char *envval)
 					rtmodules[i].putenvFunc = (PUTENVPROC) GetProcAddress(rtmodules[i].hmodule, "_putenv");
 					if (rtmodules[i].putenvFunc == NULL)
 					{
-						CloseHandle(rtmodules[i].hmodule);
 						rtmodules[i].hmodule = INVALID_HANDLE_VALUE;
 						continue;
 					}

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,6 @@ pgwin32_putenv(const char *envval)`
`92`	`92`	`rtmodules[i].putenvFunc = (PUTENVPROC) GetProcAddress(rtmodules[i].hmodule, "_putenv");`
`93`	`93`	`if (rtmodules[i].putenvFunc == NULL)`
`94`	`94`	`{`
`95`		`- CloseHandle(rtmodules[i].hmodule);`
`96`	`95`	`rtmodules[i].hmodule = INVALID_HANDLE_VALUE;`
`97`	`96`	`continue;`
`98`	`97`	`}`