Eliminate token length assumption in scanstr().

tglsfdc · tglsfdc · commit b65ab3191069 · 1999-09-11T22:26:47.000Z
diff --git a/src/backend/bootstrap/bootscanner.l b/src/backend/bootstrap/bootscanner.l
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/bootstrap/bootscanner.l,v 1.14 1999/07/17 20:16:47 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/bootstrap/bootscanner.l,v 1.15 1999/09/11 22:26:41 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -98,12 +98,17 @@ insert			{ return(INSERT_TUPLE); }
 					return(ID);
 				}
 {id}			{
-					yylval.ival = EnterString(scanstr((char*)yytext));
+					char   *newid = scanstr((char*)yytext);
+					yylval.ival = EnterString(newid);
+					pfree(newid);
 					return(ID);
 				}
 {sid}			{
+					char   *newid;
 					yytext[strlen(yytext)-1] = '\0'; /* strip off quotes */
-					yylval.ival = EnterString(scanstr((char*)yytext+1));
+					newid = scanstr((char*)yytext+1);
+					yylval.ival = EnterString(newid);
+					pfree(newid);
 					yytext[strlen(yytext)] = '"'; /* restore quotes */
 					return(ID);
 				}
diff --git a/src/backend/parser/scan.l b/src/backend/parser/scan.l
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/parser/scan.l,v 1.53 1999/09/07 00:13:27 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/parser/scan.l,v 1.54 1999/09/11 22:26:35 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -246,7 +246,7 @@ other			.
 				}
 <xq>{xqstop}	{
 					BEGIN(INITIAL);
-					yylval.str = pstrdup(scanstr(literal));
+					yylval.str = scanstr(literal);
 					return SCONST;
 				}
 <xq>{xqdouble}	|
diff --git a/src/backend/parser/scansup.c b/src/backend/parser/scansup.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/parser/scansup.c,v 1.16 1999/07/17 20:17:27 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/parser/scansup.c,v 1.17 1999/09/11 22:26:35 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -25,24 +25,26 @@
  * if the string passed in has escaped codes, map the escape codes to actual
  * chars
  *
- * the string returned is a pointer to static storage and should NOT
- * be freed by the caller.
+ * the string returned is palloc'd and should eventually be pfree'd by the
+ * caller!
  * ----------------
  */
 
 char *
 scanstr(char *s)
 {
-	static char newStr[MAX_PARSE_BUFFER];
+	char	   *newStr;
 	int			len,
 				i,
 				j;
 
 	if (s == NULL || s[0] == '\0')
-		return s;
+		return pstrdup("");
 
 	len = strlen(s);
 
+	newStr = palloc(len+1);		/* string cannot get longer */
+
 	for (i = 0, j = 0; i < len; i++)
 	{
 		if (s[i] == '\'')
diff --git a/src/interfaces/ecpg/preproc/pgc.l b/src/interfaces/ecpg/preproc/pgc.l
@@ -239,7 +239,7 @@ cppline		{space}*#.*(\\{space}*\n)*\n*
 				}
 <xq>{xqstop}	{
 					BEGIN(SQL);
-					/* yylval.str = mm_strdup(scanstr(literal));*/
+					/* yylval.str = scanstr(literal); */
 					yylval.str = mm_strdup(literal);
 					return SCONST;
 				}
@@ -601,7 +601,7 @@ cppline		{space}*#.*(\\{space}*\n)*\n*
                                      if (strcmp(old, ptr->old) == 0)
                                      {
 					free(ptr->new);
-					/* ptr->new = mm_strdup(scanstr(literal));*/
+					/* ptr->new = scanstr(literal); */
 					ptr->new = mm_strdup(literal);
                                      }
                                 }
@@ -611,7 +611,7 @@ cppline		{space}*#.*(\\{space}*\n)*\n*
 
                                         /* initial definition */
                                         this->old = old;
-                                        /* this->new = mm_strdup(scanstr(literal));*/
+                                        /* this->new = scanstr(literal); */
                                         this->new = mm_strdup(literal);
 					this->next = defines;
 					defines = this;

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/bootstrap/bootscanner.l,v 1.14 1999/07/17 20:16:47 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/bootstrap/bootscanner.l,v 1.15 1999/09/11 22:26:41 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -98,12 +98,17 @@ insert { return(INSERT_TUPLE); }`
`98`	`98`	`return(ID);`
`99`	`99`	`}`
`100`	`100`	`{id} {`
`101`		`- yylval.ival = EnterString(scanstr((char*)yytext));`
	`101`	`+ char newid = scanstr((char)yytext);`
	`102`	`+ yylval.ival = EnterString(newid);`
	`103`	`+ pfree(newid);`
`102`	`104`	`return(ID);`
`103`	`105`	`}`
`104`	`106`	`{sid} {`
	`107`	`+ char *newid;`
`105`	`108`	`yytext[strlen(yytext)-1] = '\0'; /* strip off quotes */`
`106`		`- yylval.ival = EnterString(scanstr((char*)yytext+1));`
	`109`	`+ newid = scanstr((char*)yytext+1);`
	`110`	`+ yylval.ival = EnterString(newid);`
	`111`	`+ pfree(newid);`
`107`	`112`	`yytext[strlen(yytext)] = '"'; /* restore quotes */`
`108`	`113`	`return(ID);`
`109`	`114`	`}`
Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ cppline {space}#.(\\{space}\n)\n*`
`239`	`239`	`}`
`240`	`240`	`<xq>{xqstop} {`
`241`	`241`	`BEGIN(SQL);`
`242`		`- /* yylval.str = mm_strdup(scanstr(literal));*/`
	`242`	`+ /* yylval.str = scanstr(literal); */`
`243`	`243`	`yylval.str = mm_strdup(literal);`
`244`	`244`	`return SCONST;`
`245`	`245`	`}`
`@@ -601,7 +601,7 @@ cppline {space}#.(\\{space}\n)\n*`
`601`	`601`	`if (strcmp(old, ptr->old) == 0)`
`602`	`602`	`{`
`603`	`603`	`free(ptr->new);`
`604`		`- /* ptr->new = mm_strdup(scanstr(literal));*/`
	`604`	`+ /* ptr->new = scanstr(literal); */`
`605`	`605`	`ptr->new = mm_strdup(literal);`
`606`	`606`	`}`
`607`	`607`	`}`
`@@ -611,7 +611,7 @@ cppline {space}#.(\\{space}\n)\n*`
`611`	`611`
`612`	`612`	`/* initial definition */`
`613`	`613`	`this->old = old;`
`614`		`- /* this->new = mm_strdup(scanstr(literal));*/`
	`614`	`+ /* this->new = scanstr(literal); */`
`615`	`615`	`this->new = mm_strdup(literal);`
`616`	`616`	`this->next = defines;`
`617`	`617`	`defines = this;`